Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Implement SparseSetIndex for WorldId #7125

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Implement SparseSetIndex for WorldId #7125

wants to merge 1 commit into from

Conversation

2ne1ugly
Copy link
Contributor

@2ne1ugly 2ne1ugly commented Jan 8, 2023

Objective

Solution

  • Add Hash Derive on WorldId
  • Add SparseSetIndex impl

@alice-i-cecile alice-i-cecile added A-ECS Entities, components, systems, and events C-Usability A targeted quality-of-life change that makes Bevy easier to use labels Jan 8, 2023
@mockersf mockersf added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Jan 8, 2023
@alice-i-cecile
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Jan 9, 2023
@2ne1ugly
Implement SparseSetIndex for WorldId (#7125)
ec638ad 
# Objective

- Fixes #7124

## Solution

- Add Hash Derive on `WorldId`
- Add `SparseSetIndex` impl
@bors
Copy link
Contributor

bors bot commented Jan 9, 2023

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Jan 9, 2023
@2ne1ugly
Implement SparseSetIndex for WorldId (#7125)
0e9f80e 
# Objective

- Fixes #7124

## Solution

- Add Hash Derive on `WorldId`
- Add `SparseSetIndex` impl
@bors
Copy link
Contributor

bors bot commented Jan 9, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Implement SparseSetIndex for WorldId [Merged by Bors] - Implement SparseSetIndex for WorldId Jan 9, 2023
@bors bors bot closed this Jan 9, 2023
james7132 pushed a commit to james7132/bevy that referenced this pull request Jan 21, 2023
@2ne1ugly @james7132
Implement SparseSetIndex for WorldId (bevyengine#7125)
dc857c0 
# Objective

- Fixes bevyengine#7124

## Solution

- Add Hash Derive on `WorldId`
- Add `SparseSetIndex` impl
alradish pushed a commit to alradish/bevy that referenced this pull request Jan 22, 2023
@2ne1ugly @alradish
Implement SparseSetIndex for WorldId (bevyengine#7125)
69ece02 
# Objective

- Fixes bevyengine#7124

## Solution

- Add Hash Derive on `WorldId`
- Add `SparseSetIndex` impl
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@2ne1ugly @ItsDoot
Implement SparseSetIndex for WorldId (bevyengine#7125)
68c5be7 
# Objective

- Fixes bevyengine#7124

## Solution

- Add Hash Derive on `WorldId`
- Add `SparseSetIndex` impl
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mockersf mockersf mockersf approved these changes

@james7132 james7132 james7132 approved these changes

Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make WorldId Hash and SparseSetIndex
4 participants
@2ne1ugly @alice-i-cecile @james7132 @mockersf