Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - add helper for macro to get either bevy::x or bevy_x depending on how it was imported #7164

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - add helper for macro to get either bevy::x or bevy_x depending on how it was imported #7164

wants to merge 2 commits into from

Conversation

mockersf
Copy link
Member

Objective

  • It can be useful for third party crates to work independently on how bevy is imported

Solution

  • Expose an helper to get a subcrate path for macros

@mockersf mockersf added the C-Usability A targeted quality-of-life change that makes Bevy easier to use label Jan 11, 2023
@james7132 james7132 added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Jan 11, 2023
@alice-i-cecile
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Jan 11, 2023
@mockersf
add helper for macro to get either bevy::x or bevy_x depending on how…
60be875 
… it was imported (#7164)

# Objective

- It can be useful for third party crates to work independently on how bevy is imported

## Solution

- Expose an helper to get a subcrate path for macros
@bors
Copy link
Contributor

bors bot commented Jan 11, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title add helper for macro to get either bevy::x or bevy_x depending on how it was imported [Merged by Bors] - add helper for macro to get either bevy::x or bevy_x depending on how it was imported Jan 11, 2023
@bors bors bot closed this Jan 11, 2023
alradish pushed a commit to alradish/bevy that referenced this pull request Jan 22, 2023
@mockersf @alradish
add helper for macro to get either bevy::x or bevy_x depending on how…
2ebbbb0 
… it was imported (bevyengine#7164)

# Objective

- It can be useful for third party crates to work independently on how bevy is imported

## Solution

- Expose an helper to get a subcrate path for macros
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@mockersf @ItsDoot
add helper for macro to get either bevy::x or bevy_x depending on how…
2c846ac 
… it was imported (bevyengine#7164)

# Objective

- It can be useful for third party crates to work independently on how bevy is imported

## Solution

- Expose an helper to get a subcrate path for macros
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james7132 james7132 james7132 approved these changes

@IceSentry IceSentry IceSentry approved these changes

Assignees
No one assigned
Labels
C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mockersf @alice-i-cecile @james7132 @IceSentry