[Merged by Bors] - Use toml_edit instead of toml #7327
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james7132
added
A-Build-System
tim-blackbird
approved these changes
Jan 22, 2023
mockersf
approved these changes
Jan 22, 2023
mockersf
added
the
S-Ready-For-Final-Review
CGMossa
approved these changes
Jan 22, 2023
2 tasks
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jan 22, 2023
# Objective Fixes #5675. Replace `toml` with `toml_edit` ## Solution Replace `toml` with `toml_edit`. This conveniently also removes the `serde` dependency from `bevy_macro_utils`, which may speed up cold compilation by removing the serde bottleneck from most of the macro crates in the engine.
bors
bot
changed the title
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective Fixes bevyengine#5675. Replace `toml` with `toml_edit` ## Solution Replace `toml` with `toml_edit`. This conveniently also removes the `serde` dependency from `bevy_macro_utils`, which may speed up cold compilation by removing the serde bottleneck from most of the macro crates in the engine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #5675. Replace
tomlwithtoml_editSolution
Replace
tomlwithtoml_edit. This conveniently also removes theserdedependency frombevy_macro_utils, which may speed up cold compilation by removing the serde bottleneck from most of the macro crates in the engine.