[Merged by Bors] - Rename Tick::is_older_than to Tick::is_newer_than
#7561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
C-Bug
alice-i-cecile
approved these changes
Feb 8, 2023
alice-i-cecile
added
the
M-Needs-Migration-Guide
JoJoJet
reviewed
Feb 8, 2023
JoJoJet
approved these changes
Feb 9, 2023
alice-i-cecile
added
the
S-Ready-For-Final-Review
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Feb 9, 2023
# Objective Clarify what the function is actually calculating. The `Tick::is_older_than` function is actually calculating whether the tick is newer than the system's `last_change_tick`, not older. As far as I can tell, the engine was using it correctly everywhere already. ## Solution - Rename the function. --- ## Changelog - `Tick::is_older_than` was renamed to `Tick::is_newer_than`. This is not a functional change, since that was what was always being calculated, despite the wrong name. ## Migration Guide - Replace usages of `Tick::is_older_than` with `Tick::is_newer_than`.
|
Pull request successfully merged into main. Build succeeded:
|
bors
bot
changed the title
Tick::is_older_than to Tick::is_newer_thanTick::is_older_than to Tick::is_newer_than
myreprise1
pushed a commit
to myreprise1/bevy
that referenced
this pull request
Feb 11, 2023
# Objective Clarify what the function is actually calculating. The `Tick::is_older_than` function is actually calculating whether the tick is newer than the system's `last_change_tick`, not older. As far as I can tell, the engine was using it correctly everywhere already. ## Solution - Rename the function. --- ## Changelog - `Tick::is_older_than` was renamed to `Tick::is_newer_than`. This is not a functional change, since that was what was always being calculated, despite the wrong name. ## Migration Guide - Replace usages of `Tick::is_older_than` with `Tick::is_newer_than`.
myreprise1
pushed a commit
to myreprise1/bevy
that referenced
this pull request
Feb 11, 2023
# Objective Clarify what the function is actually calculating. The `Tick::is_older_than` function is actually calculating whether the tick is newer than the system's `last_change_tick`, not older. As far as I can tell, the engine was using it correctly everywhere already. ## Solution - Rename the function. --- ## Changelog - `Tick::is_older_than` was renamed to `Tick::is_newer_than`. This is not a functional change, since that was what was always being calculated, despite the wrong name. ## Migration Guide - Replace usages of `Tick::is_older_than` with `Tick::is_newer_than`.
myreprise1
pushed a commit
to myreprise1/bevy
that referenced
this pull request
Feb 15, 2023
# Objective Clarify what the function is actually calculating. The `Tick::is_older_than` function is actually calculating whether the tick is newer than the system's `last_change_tick`, not older. As far as I can tell, the engine was using it correctly everywhere already. ## Solution - Rename the function. --- ## Changelog - `Tick::is_older_than` was renamed to `Tick::is_newer_than`. This is not a functional change, since that was what was always being calculated, despite the wrong name. ## Migration Guide - Replace usages of `Tick::is_older_than` with `Tick::is_newer_than`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Clarify what the function is actually calculating.
The
Tick::is_older_thanfunction is actually calculating whether the tick is newer than the system'slast_change_tick, not older. As far as I can tell, the engine was using it correctly everywhere already.Solution
Changelog
Tick::is_older_thanwas renamed toTick::is_newer_than. This is not a functional change, since that was what was always being calculated, despite the wrong name.Migration Guide
Tick::is_older_thanwithTick::is_newer_than.