Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - add setup function to app #7586

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - add setup function to app #7586

wants to merge 2 commits into from

Conversation

hymm
Copy link
Contributor

@hymm hymm commented Feb 9, 2023

Objective

Solution

  • Add a setup function to app, so users can call the plugin setup methods before calling update.

Changelog

  • add a setup function to app

@alice-i-cecile alice-i-cecile added C-Bug An unexpected or incorrect behavior C-Usability A targeted quality-of-life change that makes Bevy easier to use A-App Bevy apps and plugins labels Feb 9, 2023
@alice-i-cecile alice-i-cecile added this to the 0.10 milestone Feb 9, 2023
alice-i-cecile
alice-i-cecile approved these changes Feb 9, 2023
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not my favorite solution (I want AppBuilder back), but a good enough fix for the impending release.

tim-blackbird
tim-blackbird approved these changes Feb 9, 2023
View reviewed changes
crates/bevy_app/src/app.rs Outdated Show resolved Hide resolved
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Feb 9, 2023
@alice-i-cecile
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Feb 9, 2023
@hymm
add setup function to app (#7586)
eeb67ee 
# Objective

- Fixes #7412
- Fixes #7576 

## Solution

- Add a setup function to app, so users can call the plugin `setup` methods before calling `update`.

## Changelog

- add a setup function to app
@bors
Copy link
Contributor

bors bot commented Feb 9, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title add setup function to app [Merged by Bors] - add setup function to app Feb 9, 2023
@bors bors bot closed this Feb 9, 2023
myreprise1 pushed a commit to myreprise1/bevy that referenced this pull request Feb 11, 2023
@hymm @myreprise1
add setup function to app (bevyengine#7586)
d12f9e3 
# Objective

- Fixes bevyengine#7412
- Fixes bevyengine#7576 

## Solution

- Add a setup function to app, so users can call the plugin `setup` methods before calling `update`.

## Changelog

- add a setup function to app
myreprise1 pushed a commit to myreprise1/bevy that referenced this pull request Feb 11, 2023
@hymm @myreprise1
add setup function to app (bevyengine#7586)
a179e6a 
# Objective

- Fixes bevyengine#7412
- Fixes bevyengine#7576 

## Solution

- Add a setup function to app, so users can call the plugin `setup` methods before calling `update`.

## Changelog

- add a setup function to app
myreprise1 pushed a commit to myreprise1/bevy that referenced this pull request Feb 15, 2023
@hymm @myreprise1
add setup function to app (bevyengine#7586)
19a8493 
# Objective

- Fixes bevyengine#7412
- Fixes bevyengine#7576 

## Solution

- Add a setup function to app, so users can call the plugin `setup` methods before calling `update`.

## Changelog

- add a setup function to app
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@tim-blackbird tim-blackbird tim-blackbird approved these changes

Assignees
No one assigned
Labels
A-App Bevy apps and plugins C-Bug An unexpected or incorrect behavior C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
0.10
3 participants
@hymm @alice-i-cecile @tim-blackbird