-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI Display and Visibility Example #7629
Conversation
* split up setup function * added instructions text to example
You added a new example but didn't add metadata for it. Please update the root Cargo.toml file. |
With all of the nodes arranged in a hierarchy as they are, aren't Would it be more interesting to show the clickable nodes in a single parent flex container? |
I'm not quite sure what you mean, the behaviour is quite different isn't it? |
That's fair. When I think of the difference between Although I'm not sure how to demonstrate both properties simultaneously.
|
Oh I get it, you are right. It needs to demonstrate how |
…o that it collapses when `Display::None` is set on its child.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with a couple of nits that I think are worth adding… but, up to you.
Nice example 👍
@ickshonpe can you fix the conflicts and make a call on the nits? I think they're an improvement, but I won't block on them. |
Yep I'll take a look |
You added a new example but didn't update the readme. Please run |
1 similar comment
You added a new example but didn't update the readme. Please run |
…the text components directly to the `ButtonBundle`s.
You added a new example but didn't update the readme. Please run |
1 similar comment
You added a new example but didn't update the readme. Please run |
… is red when properties set to `Display::None` or `Visibility::Hidden`.
You added a new example but didn't update the readme. Please run |
Everything resolved, should be ready as long as its passes CI checks. |
Objective
An example demonstrating how Display and Visibility work in Bevy UI.
fixes #5380
related #5368
Changelog
flex_display.rs
.