[Merged by Bors] - Allow shared access to SyncCell for types that are already Sync
#7718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoJoJet
added
C-Feature
james7132
approved these changes
Feb 16, 2023
james7132
added
the
S-Ready-For-Final-Review
mockersf
approved these changes
Feb 16, 2023
harudagondi
approved these changes
Feb 17, 2023
5 tasks
bors bot
pushed a commit
that referenced
this pull request
Feb 17, 2023
…7718) # Objective The type `SyncCell<T>` (added in #5483) is used to force any wrapped type to be `Sync`, by only allowing exclusive access to the wrapped value. This restriction is unnecessary for types which are already `Sync`. --- ## Changelog + Added the method `read` to `SyncCell`, which allows shared access to values that already implement the `Sync` trait.
|
Pull request successfully merged into main. Build succeeded:
|
bors
bot
changed the title
SyncCell for types that are already SyncSyncCell for types that are already Sync
myreprise1
pushed a commit
to myreprise1/bevy
that referenced
this pull request
Feb 18, 2023
…evyengine#7718) # Objective The type `SyncCell<T>` (added in bevyengine#5483) is used to force any wrapped type to be `Sync`, by only allowing exclusive access to the wrapped value. This restriction is unnecessary for types which are already `Sync`. --- ## Changelog + Added the method `read` to `SyncCell`, which allows shared access to values that already implement the `Sync` trait.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
The type
SyncCell<T>(added in #5483) is used to force any wrapped type to beSync, by only allowing exclusive access to the wrapped value. This restriction is unnecessary for types which are alreadySync.Changelog
readtoSyncCell, which allows shared access to values that already implement theSynctrait.