[Merged by Bors] - Use correct terminology for a NonSend run condition panic
#7841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoJoJet
added
A-ECS
JoJoJet
commented
Feb 28, 2023
Comment on lines
59
to
63
| assert!( | ||
| condition_system.is_send(), | ||
| "Condition `{}` accesses thread-local resources. This is not currently supported.", | ||
| "Condition `{}` accesses `NonSend` resources. This is not currently supported.", | ||
| condition_system.name() | ||
| ); |
There was a problem hiding this comment.
I want to note that this assert currently does nothing, since a system's "send-ness" only gets set when it's initialized. This assert never gets triggered, so instead a panic occurs later on when the system actually tries to access a NonSend resource from the wrong thread. I'm not sure what the best solution to this is, but it's probably worth opening an issue about it.
alice-i-cecile
approved these changes
Feb 28, 2023
alice-i-cecile
added
the
S-Ready-For-Final-Review
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Feb 28, 2023
# Objective There is a panic that occurs when creating a run condition that accesses `NonSend` resources, but it refers to them as 'thread-local' resources instead. ## Solution Correct the terminology.
|
Pull request successfully merged into main. Build succeeded:
|
bors
bot
changed the title
NonSend run condition panicNonSend run condition panic
Shfty
pushed a commit
to shfty-rust/bevy
that referenced
this pull request
Mar 19, 2023
…ne#7841) # Objective There is a panic that occurs when creating a run condition that accesses `NonSend` resources, but it refers to them as 'thread-local' resources instead. ## Solution Correct the terminology.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
There is a panic that occurs when creating a run condition that accesses
NonSendresources, but it refers to them as 'thread-local' resources instead.Solution
Correct the terminology.