-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document bevy_gizmos
#8186
Document bevy_gizmos
#8186
Conversation
Once there's module docs this LGTM. Solid work so far, and I like the gratuitous use of doc examples. |
It looks like your PR is a breaking change, but you didn't provide a migration guide. Could you add some context on what users should update when this change get released in a new version of Bevy? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs look good to me. The removal of GizmosBuffer
as a pub struct is a breaking change though, as is the change from a alias to a actual struct.
Co-authored-by: James Liu <[email protected]>
Thanks for the review! |
Ah yeah, you're right. Thanks for noting that. |
Objective
Fix #8179
Solution
#![warn(missing_docs)]
and document all public items. All methods onGizmos
have doc examples.GizmoBuffer
to be directly onGizmos
and madeGizmoBuffer
private. This means the methods onGizmos
will show up on its doc page.