Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update increment_change_tick to return a strongly-typed Tick #8295

Merged
merged 1 commit into from
Apr 3, 2023
Merged

Update increment_change_tick to return a strongly-typed Tick #8295

merged 1 commit into from
Apr 3, 2023

Conversation

JoJoJet
Copy link
Member

@JoJoJet JoJoJet commented Apr 3, 2023

Objective

While migrating the engine to use the Tick type in #7905, I forgot to update UnsafeWorldCell::increment_change_tick.

Solution

Update the function.

Changelog

  • The function UnsafeWorldCell::increment_change_tick is now strongly-typed, returning a value of type Tick instead of a raw u32.

Migration Guide

The function UnsafeWorldCell::increment_change_tick is now strongly-typed, returning a value of type Tick instead of a raw u32.

@JoJoJet JoJoJet added A-ECS Entities, components, systems, and events C-Usability A targeted quality-of-life change that makes Bevy easier to use M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide labels Apr 3, 2023
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Apr 3, 2023
@james7132 james7132 added this pull request to the merge queue Apr 3, 2023
Merged via the queue into bevyengine:main with commit 086db6d Apr 3, 2023
@JoJoJet JoJoJet deleted the increment-tick branch April 3, 2023 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james7132 james7132 james7132 approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Usability A targeted quality-of-life change that makes Bevy easier to use M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JoJoJet @james7132 @alice-i-cecile