Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bevy_ui: Add FromReflect derives #8495

Merged
merged 1 commit into from
Apr 26, 2023
Merged

bevy_ui: Add FromReflect derives #8495

merged 1 commit into from
Apr 26, 2023

Conversation

MrGVSV
Copy link
Member

@MrGVSV MrGVSV commented Apr 26, 2023 •
edited
Loading

Objective

A lot of items in bevy_ui could be FromReflect but aren't. This prevents users and library authors from being able to convert from a dyn Reflect to one of these items.

Solution

Derive FromReflect where possible. Also register the ReflectFromReflect type data.

@MrGVSV MrGVSV added A-UI Graphical user interfaces, styles, layouts, and widgets C-Usability A targeted quality-of-life change that makes Bevy easier to use A-Reflection Runtime information about types labels Apr 26, 2023
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Apr 26, 2023
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Apr 26, 2023
Merged via the queue into bevyengine:main with commit 85c3251 Apr 26, 2023
@MrGVSV MrGVSV deleted the reflect-ui-from-reflect branch April 26, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@TimJentzsch TimJentzsch TimJentzsch approved these changes

Assignees
No one assigned
Labels
A-Reflection Runtime information about types A-UI Graphical user interfaces, styles, layouts, and widgets C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
Reflection
Status: In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MrGVSV @alice-i-cecile @TimJentzsch