Improve encapsulation for commands and add docs #8725
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Several of our built-in
Command
types are too public:GetOrSpawn
is public, even though it only makes sense to call it from withinCommands::get_or_spawn
.Remove
andRemoveResource
contain publicPhantomData
marker fields.Solution
Remove
GetOrSpawn
and use an anonymous command. Make the marker fields private.Migration Guide
The
Command
typesRemove
andRemoveResource
may no longer be constructed manually.The command type
GetOrSpawn
has been removed. It was not possible to use this type outside ofbevy_ecs
.