Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify the implementation of UnsafeWorldCell #8727

Closed
wants to merge 2 commits into from
Closed

Simplify the implementation of UnsafeWorldCell #8727

wants to merge 2 commits into from

Conversation

JoJoJet
Copy link
Member

@JoJoJet JoJoJet commented May 31, 2023

Objective

The type UnsafeWorldCell is essentially a manual implementation of SyncUnsafeCell, which is unnecessary.

Solution

Make UnsafeWorldCell a wrapper around SyncUnsafeCell.

@james7132 james7132 added A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change labels May 31, 2023
@james7132 james7132 self-requested a review May 31, 2023 16:53
@JoJoJet
Copy link
Member Author

JoJoJet commented May 31, 2023

Closing this for now. Even though I believe this is correct, miri doesn't like it so it's not worth the trouble.

@JoJoJet JoJoJet closed this May 31, 2023
@JoJoJet JoJoJet deleted the simplify-uwc branch May 31, 2023 17:03
@JoJoJet
Copy link
Member Author

JoJoJet commented Jun 2, 2023

Looks like Miri is failing due to this issue. This should be fixed with Tree Borrows, whenever that lands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james7132 james7132 Awaiting requested review from james7132

Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoJoJet @james7132