Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix normal prepass #8890

Merged
merged 5 commits into from
Jun 21, 2023
Merged

fix normal prepass #8890

merged 5 commits into from
Jun 21, 2023

Conversation

IceSentry
Copy link
Contributor

@IceSentry IceSentry commented Jun 19, 2023 •
edited
Loading

Objective

  • Fix broken normals when the NormalPrepass is enabled

Solution

  • Don't use the normal prepass for the world_normal
  • Only loadthe normal prepass
    • when msaa is disabled
    • for opaque or alpha mask meshes and only for use it for N not world_normal

@IceSentry IceSentry added A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior labels Jun 19, 2023
@alice-i-cecile alice-i-cecile added this to the 0.11 milestone Jun 19, 2023
@JMS55
Copy link
Contributor

JMS55 commented Jun 19, 2023

Closes the non-parallax mapping parts of #8746

@IceSentry
Copy link
Contributor Author

Closes #8746

@nicopap nicopap added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Jun 21, 2023
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jun 21, 2023
@alice-i-cecile alice-i-cecile mentioned this pull request Jun 21, 2023
Closed
Merged via the queue into bevyengine:main with commit 72b4aac Jun 21, 2023
@Elabajaba Elabajaba mentioned this pull request Jun 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicopap nicopap nicopap approved these changes

@JMS55 JMS55 JMS55 approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
0.11
Development

Successfully merging this pull request may close these issues.
4 participants
@IceSentry @JMS55 @nicopap @alice-i-cecile