Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One Shot Systems #8963

Merged
merged 114 commits into from
Sep 19, 2023
Merged

One Shot Systems #8963

merged 114 commits into from
Sep 19, 2023

Commits on Aug 28, 2023

  1. Basic functionality

    alice-i-cecile authored and Trashtalk217 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    844524b View commit details
    Browse the repository at this point in the history
  2. commands.run_system

    alice-i-cecile authored and Trashtalk217 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    c8ddefd View commit details
    Browse the repository at this point in the history
  3. Add SystemRegistry resource as part of CorePlugin

    No plugin exists for bevy_ecs, so this was the best place.
    alice-i-cecile authored and Trashtalk217 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    945c81f View commit details
    Browse the repository at this point in the history
  4. Run system by TypeId

    alice-i-cecile authored and Trashtalk217 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    655bf2e View commit details
    Browse the repository at this point in the history
  5. Fix doc links

    alice-i-cecile authored and Trashtalk217 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    7f7bc4a View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    ac35f19 View commit details
    Browse the repository at this point in the history
  7. Always flush commands from systems

    Only the commands specific to this system are applied, so we should de-emphasize this choice.
    alice-i-cecile authored and Trashtalk217 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    549d2eb View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    d6c2fd2 View commit details
    Browse the repository at this point in the history
  9. Add test suite

    alice-i-cecile authored and Trashtalk217 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    d39092d View commit details
    Browse the repository at this point in the history
  10. Doc improvements

    alice-i-cecile authored and Trashtalk217 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    63a0707 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    89b045c View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    67c27fc View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    3e205aa View commit details
    Browse the repository at this point in the history
  14. Doc tests for SystemRegistry

    alice-i-cecile authored and Trashtalk217 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    c16fab6 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    6cabe3e View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    157d48a View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    b96c695 View commit details
    Browse the repository at this point in the history
  18. Note limitations

    alice-i-cecile authored and Trashtalk217 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    8df48ee View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    f3d15b0 View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    6c59d39 View commit details
    Browse the repository at this point in the history
  21. Revert "Move SystemRegistry to a field on World"

    This reverts commit ba66966.
    alice-i-cecile authored and Trashtalk217 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    1ecf7d4 View commit details
    Browse the repository at this point in the history
  22. Clippy fixes

    alice-i-cecile authored and Trashtalk217 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    6efb44a View commit details
    Browse the repository at this point in the history
  23. Clippy fix

    alice-i-cecile authored and Trashtalk217 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    29021bb View commit details
    Browse the repository at this point in the history
  24. System recursion should fail

    alice-i-cecile authored and Trashtalk217 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    a7d0260 View commit details
    Browse the repository at this point in the history
  25. Documentation improvements

    alice-i-cecile authored and Trashtalk217 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    07e7caa View commit details
    Browse the repository at this point in the history
  26. Nicer error handling

    alice-i-cecile authored and Trashtalk217 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    23b0768 View commit details
    Browse the repository at this point in the history
  27. Configuration menu
    Copy the full SHA
    273113b View commit details
    Browse the repository at this point in the history
  28. Fix off by one error

    alice-i-cecile authored and Trashtalk217 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    bbe6dc6 View commit details
    Browse the repository at this point in the history
  29. Reduce noisy returns

    alice-i-cecile authored and Trashtalk217 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    0c4bfb5 View commit details
    Browse the repository at this point in the history
  30. Fix broken tests

    alice-i-cecile authored and Trashtalk217 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    6e45a31 View commit details
    Browse the repository at this point in the history
  31. Add example

    alice-i-cecile authored and Trashtalk217 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    085a21d View commit details
    Browse the repository at this point in the history
  32. Configuration menu
    Copy the full SHA
    2316077 View commit details
    Browse the repository at this point in the history
  33. Formatting

    alice-i-cecile authored and Trashtalk217 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    ccbe49f View commit details
    Browse the repository at this point in the history
  34. Configuration menu
    Copy the full SHA
    f9d0348 View commit details
    Browse the repository at this point in the history
  35. Configuration menu
    Copy the full SHA
    184cd6b View commit details
    Browse the repository at this point in the history
  36. Polish example

    alice-i-cecile authored and Trashtalk217 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    45bba7d View commit details
    Browse the repository at this point in the history
  37. Update examples README per CI

    alice-i-cecile authored and Trashtalk217 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    f63b221 View commit details
    Browse the repository at this point in the history
  38. Configuration menu
    Copy the full SHA
    4e21f4b View commit details
    Browse the repository at this point in the history
  39. Fix broken link

    Co-authored-by: Federico Rinaldi <[email protected]>
    2 people authored and Trashtalk217 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    46e7092 View commit details
    Browse the repository at this point in the history
  40. Configuration menu
    Copy the full SHA
    5d275ff View commit details
    Browse the repository at this point in the history
  41. Configuration menu
    Copy the full SHA
    24508d1 View commit details
    Browse the repository at this point in the history
  42. Implement Hash for Callback

    alice-i-cecile authored and Trashtalk217 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    0855a0f View commit details
    Browse the repository at this point in the history
  43. Configuration menu
    Copy the full SHA
    8effb5b View commit details
    Browse the repository at this point in the history
  44. Fix doc example

    alice-i-cecile authored and Trashtalk217 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    9191f12 View commit details
    Browse the repository at this point in the history
  45. Manually implement Hash

    alice-i-cecile authored and Trashtalk217 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    973be53 View commit details
    Browse the repository at this point in the history
  46. Fix doc example (for real?)

    alice-i-cecile authored and Trashtalk217 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    aedd75b View commit details
    Browse the repository at this point in the history
  47. Avoid box allocation

    Co-authored-by: MinerSebas <[email protected]>
    2 people authored and Trashtalk217 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    69e8039 View commit details
    Browse the repository at this point in the history
  48. Mostly fix doc example

    alice-i-cecile authored and Trashtalk217 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    f2b398a View commit details
    Browse the repository at this point in the history
  49. Configuration menu
    Copy the full SHA
    98ed955 View commit details
    Browse the repository at this point in the history
  50. Typo fix

    Co-authored-by: Aevyrie <[email protected]>
    2 people authored and Trashtalk217 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    7476695 View commit details
    Browse the repository at this point in the history
  51. Configuration menu
    Copy the full SHA
    4756690 View commit details
    Browse the repository at this point in the history
  52. Punctuation

    Co-authored-by: Federico Rinaldi <[email protected]>
    2 people authored and Trashtalk217 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    56d09f5 View commit details
    Browse the repository at this point in the history
  53. Typo

    Co-authored-by: Aevyrie <[email protected]>
    2 people authored and Trashtalk217 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    bf42626 View commit details
    Browse the repository at this point in the history
  54. Configuration menu
    Copy the full SHA
    d553b1e View commit details
    Browse the repository at this point in the history
  55. Configuration menu
    Copy the full SHA
    3ec4643 View commit details
    Browse the repository at this point in the history
  56. Configuration menu
    Copy the full SHA
    6a49a83 View commit details
    Browse the repository at this point in the history
  57. Configuration menu
    Copy the full SHA
    d60b6cf View commit details
    Browse the repository at this point in the history
  58. Configuration menu
    Copy the full SHA
    e1b5ccd View commit details
    Browse the repository at this point in the history
  59. Configuration menu
    Copy the full SHA
    2f3e570 View commit details
    Browse the repository at this point in the history
  60. fix doc tests

    Pascualex authored and Trashtalk217 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    aa43356 View commit details
    Browse the repository at this point in the history
  61. remove run_systems_by_set

    Pascualex authored and Trashtalk217 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    7a2b873 View commit details
    Browse the repository at this point in the history
  62. Configuration menu
    Copy the full SHA
    ffdbd9b View commit details
    Browse the repository at this point in the history
  63. rename params to marker

    Pascualex authored and Trashtalk217 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    eea7e16 View commit details
    Browse the repository at this point in the history
  64. key systems by SystemId

    Pascualex authored and Trashtalk217 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    95efbb0 View commit details
    Browse the repository at this point in the history
  65. Configuration menu
    Copy the full SHA
    b035e3b View commit details
    Browse the repository at this point in the history
  66. Configuration menu
    Copy the full SHA
    383cbeb View commit details
    Browse the repository at this point in the history
  67. Configuration menu
    Copy the full SHA
    cd0e7c5 View commit details
    Browse the repository at this point in the history
  68. Configuration menu
    Copy the full SHA
    dea567f View commit details
    Browse the repository at this point in the history
  69. Configuration menu
    Copy the full SHA
    f47629b View commit details
    Browse the repository at this point in the history
  70. cargo fmt

    Trashtalk217 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    c396859 View commit details
    Browse the repository at this point in the history
  71. Configuration menu
    Copy the full SHA
    7c8e15b View commit details
    Browse the repository at this point in the history
  72. Configuration menu
    Copy the full SHA
    5061e55 View commit details
    Browse the repository at this point in the history
  73. Fix test, cleanup

    Trashtalk217 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    72b994f View commit details
    Browse the repository at this point in the history
  74. Configuration menu
    Copy the full SHA
    64ad487 View commit details
    Browse the repository at this point in the history
  75. Configuration menu
    Copy the full SHA
    1098cd5 View commit details
    Browse the repository at this point in the history
  76. Configuration menu
    Copy the full SHA
    d9c89d9 View commit details
    Browse the repository at this point in the history
  77. Configuration menu
    Copy the full SHA
    5e50d02 View commit details
    Browse the repository at this point in the history
  78. Configuration menu
    Copy the full SHA
    c954f0d View commit details
    Browse the repository at this point in the history
  79. Configuration menu
    Copy the full SHA
    aa15370 View commit details
    Browse the repository at this point in the history
  80. Configuration menu
    Copy the full SHA
    47c75fc View commit details
    Browse the repository at this point in the history
  81. Remove outdated comments

    Trashtalk217 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    1963e63 View commit details
    Browse the repository at this point in the history
  82. Fix CI for Rust 1.72 (bevyengine#9562)

    [Rust 1.72.0](https://blog.rust-lang.org/2023/08/24/Rust-1.72.0.html) is
    now stable.
    
    - `let-else` formatting has arrived!
    - I chose to allow `explicit_iter_loop` due to
    rust-lang/rust-clippy#11074.
    
    We didn't hit any of the false positives that prevent compilation, but
    fixing this did produce a lot of the "symbol soup" mentioned, e.g. `for
    image in &mut *image_events {`.
    
      Happy to undo this if there's consensus the other way.
    
    ---------
    
    Co-authored-by: François <[email protected]>
    2 people authored and Trashtalk217 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    069db4b View commit details
    Browse the repository at this point in the history
  83. Add example

    alice-i-cecile authored and Trashtalk217 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    afe255e View commit details
    Browse the repository at this point in the history
  84. remove run_systems_by_set

    Pascualex authored and Trashtalk217 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    f565203 View commit details
    Browse the repository at this point in the history
  85. Configuration menu
    Copy the full SHA
    948147f View commit details
    Browse the repository at this point in the history
  86. Configuration menu
    Copy the full SHA
    9195849 View commit details
    Browse the repository at this point in the history
  87. Revert "Add example"

    This reverts commit afe255e.
    Trashtalk217 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    29837c6 View commit details
    Browse the repository at this point in the history
  88. Revert "Fix CI for Rust 1.72 (bevyengine#9562)"

    This reverts commit 069db4b.
    Trashtalk217 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    ebf4b99 View commit details
    Browse the repository at this point in the history
  89. Fixed tests

    Trashtalk217 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    9d15661 View commit details
    Browse the repository at this point in the history
  90. Configuration menu
    Copy the full SHA
    47c67b3 View commit details
    Browse the repository at this point in the history
  91. cargo fmt

    Trashtalk217 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    478e5fd View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2023

  1. Configuration menu
    Copy the full SHA
    1b4e95c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9f6a426 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0a41754 View commit details
    Browse the repository at this point in the history
  4. appease the CI

    Trashtalk217 committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    12c067f View commit details
    Browse the repository at this point in the history
  5. fixed doc test

    Trashtalk217 committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    e646e9c View commit details
    Browse the repository at this point in the history
  6. fixed doc example 2

    Trashtalk217 committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    17ad075 View commit details
    Browse the repository at this point in the history
  7. fixed doc test 3

    Trashtalk217 committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    d1e7e4c View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2023

  1. Changes from code review

    Trashtalk217 committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    61986c3 View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2023

  1. Configuration menu
    Copy the full SHA
    c6de53d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ea30824 View commit details
    Browse the repository at this point in the history
  3. spelling mistake

    Trashtalk217 committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    ff61574 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2023

  1. Configuration menu
    Copy the full SHA
    66b688c View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2023

  1. Update crates/bevy_ecs/src/system/system.rs

    Co-authored-by: Dmytro Banin <[email protected]>
    Trashtalk217 and dmyyy committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    7bacdf2 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2023

  1. Configuration menu
    Copy the full SHA
    83b898b View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2023

  1. Configuration menu
    Copy the full SHA
    d01a23e View commit details
    Browse the repository at this point in the history
  2. trimmed API

    Trashtalk217 committed Sep 9, 2023
    Configuration menu
    Copy the full SHA
    c4c94e6 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d2e9ac7 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    bcb7687 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2023

  1. Configuration menu
    Copy the full SHA
    0b8f8dc View commit details
    Browse the repository at this point in the history
  2. cargo fmt

    Trashtalk217 committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    cdaecfc View commit details
    Browse the repository at this point in the history
  3. fixed doc tests

    Trashtalk217 committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    e5fbad0 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2023

  1. Updated documentation

    Trashtalk217 committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    99166fe View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    aa81e3f View commit details
    Browse the repository at this point in the history