Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relax FnMut to FnOnce in app::edit_schedule #8982

Merged
merged 1 commit into from
Jun 29, 2023
Merged

Relax FnMut to FnOnce in app::edit_schedule #8982

merged 1 commit into from
Jun 29, 2023

Conversation

nakedible
Copy link
Contributor

Objective

Currently App::edit_schedule takes in impl FnMut(&mut Schedule), but it calls the function only once. It is probably the intention has been to have it take FnOnce instead.

Solution

  • Relax the parameter to take FnOnce instead of FnMut

@nakedible nakedible marked this pull request as ready for review June 28, 2023 12:19
@alice-i-cecile alice-i-cecile added A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change C-Usability A targeted quality-of-life change that makes Bevy easier to use A-App Bevy apps and plugins labels Jun 28, 2023
@hymm hymm added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Jun 28, 2023
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jun 29, 2023
Merged via the queue into bevyengine:main with commit ab3b429 Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hymm hymm hymm approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@tim-blackbird tim-blackbird tim-blackbird approved these changes

Assignees
No one assigned
Labels
A-App Bevy apps and plugins A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nakedible @hymm @alice-i-cecile @tim-blackbird