impl From<&AssetPath>
for HandleId
#9132
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
In
AssetLoader::load()
, I have anAssetPath
to a dependency asset.I get a handle to this dependency asset using
LoadContext::get_handle()
passing theAssetPath
. But I also need to pass thisAssetPath
toLoadedAsset::with_dependency()
later.The current solution for this problem is either use
clone()
, butAssetPath
may contains owned data.Or to use
AssetPathId::from(&path)
which is a bit verbose.Ideal solution (introduced by this PR) is to pass a reference to
get_handle()
.Solution
Implement
From<&AssetPath>
forHandleId
Changelog
HandleId
can be build from a reference toAssetPath
.