-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Pitch as an alternative sound source #9225
Conversation
Welcome, new contributor! Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨ |
Looks good! Could you find another name than For the example, could you add a dedicated example in the Audio category instead of changing the breakout one? |
Sure, I guess the correct name would be pure tone, so maybe
Of course, I guess I jumped the gun a little bit because of this comment |
I think |
You added a new example but didn't update the readme. Please run |
I changed the name and added example, but I don't know how to fix the failing check. Could you help me with that, please? |
The dependencies/check-bans failure is not because of your PR, and it's not required so it can be ignore. I would love for the example to be a little more interactive. For example react to key press to play a sound, and displaying a text like "press to play a sound". If you're filling more adventurous you could even display the current frequency, and change it up/down on arrow up/down press. |
So, something like this with more comments? I think it overcomplicates the example |
I think it's great, thanks! if you run |
Doc suggestions are just nits to help users who aren't familiar with the terminology. No objections to merging this as is though. |
Changed description with clarification of what pitch is Co-authored-by: Alice Cecile <[email protected]>
Objective
My attempt at implementing #7515
Solution
Added struct
Pitch
and implemented on itSource
trait.Changelog
Added
Pitch
and type aliases forAudioSourceBundle<Pitch>
andSpatialAudioSourceBundle<Pitch>
PitchBundle
Changed
AudioPlugin
now adds system forPitch
audio