Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the With<Parent> query filter from bevy_ui::render::extract_uinode_borders #9285

Merged
merged 3 commits into from
Jul 31, 2023
Merged

Remove the With<Parent> query filter from bevy_ui::render::extract_uinode_borders #9285

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4658841
`bevy_ui::render::extract_uinode_borders`
ickshonpe Jul 26, 2023
e779a4d
Update crates/bevy_ui/src/render/mod.rs
ickshonpe Jul 31, 2023
b387529
Completed the renaming.
ickshonpe Jul 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/bevy_ui/src/render/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,7 +277,7 @@ pub fn extract_uinode_borders(
Without<ContentSize>,
>,
>,
parent_node_query: Extract<Query<&Node, With<Parent>>>,
parent_node_query: Extract<Query<&Node>>,
Copy link
Member

@mockersf mockersf Jul 29, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
parent_node_query: Extract<Query<&Node>>,
node_query: Extract<Query<&Node>>,

and also where it's used

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, since it's the query used to get the parent, it makes sense to be named "parent_node_query"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to name it based on what is is, not where it's used

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to name it based on what is is, not where it's used

agreed I think, but keep the name parent_node for the value retrieved from the query, where it is the actual Node component of the parent.

) {
let image = bevy_render::texture::DEFAULT_IMAGE_HANDLE.typed();

Expand Down