Make it so ParsedPath
can be passed to GetPath
#9373
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
ParsedPath
andGetPath
APIs. They weirdly didn't play well together.ParsedPath
andGetPath
API easier to useSolution
ReflectPath
trait.GetPath
methods now accept animpl ReflectPath<'a>
instead of a&'a str
, this mean it also can accepts a&ParsedPath
GetPath: Reflect
and use default impl forReflect
types.GetPath
andReflectPath
to thebevy_reflect
preludeChangelog
ReflectPath
trait.GetPath
methods now accept animpl ReflectPath<'a>
instead of a&'a str
, this mean it also can accept a&ParsedPath
GetPath: Reflect
and use default impl forReflect
types.GetPath
andReflectPath
to thebevy_reflect
preludeMigration Guide
GetPath
now requiresReflect
. This reduces a lot of boilerplate on bevy's side. If you were implementing manuallyGetPath
on your own type, please get in touch!ParsedPath::element[_mut]
isn't an inherent method ofParsedPath
, you must now importReflectPath
. This is only relevant if you weren't importing the bevy prelude.