Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix errors and panics to typical Rust conventions #968

Merged
merged 2 commits into from
Dec 2, 2020
Merged

Fix errors and panics to typical Rust conventions #968

merged 2 commits into from
Dec 2, 2020

Conversation

joshuajbouw
Copy link
Member

Since Rust has such a nice error and panic display, its best to follow the conventions of it to make grammatical sense. This generally is sentence fragments for errors, and then full sentences for panics. Tried to catch as many as I could.

Just a wee bit of clean up.

ambeeeeee
ambeeeeee suggested changes Dec 1, 2020
View reviewed changes
Copy link
Contributor

@ambeeeeee ambeeeeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting that the only previously consistently capitalized errors are the ones that should not be capitalized :(

crates/bevy_reflect/bevy_reflect_derive/src/type_uuid.rs Outdated Show resolved Hide resolved
crates/bevy_reflect/bevy_reflect_derive/src/type_uuid.rs Outdated Show resolved Hide resolved
crates/bevy_scene/src/scene_spawner.rs Show resolved Hide resolved
crates/bevy_wgpu/src/renderer/wgpu_render_context.rs Outdated Show resolved Hide resolved
@memoryruins memoryruins added the C-Code-Quality A section of code that is hard to understand or change label Dec 2, 2020
@cart
Copy link
Member

cart commented Dec 2, 2020

Looks good to me. Haha I have a feeling it will take some time for my brain to adjust to this.

@cart cart merged commit 9f4c8b1 into bevyengine:master Dec 2, 2020
@joshuajbouw joshuajbouw deleted the std-error branch December 3, 2020 04:04
@fopsdev fopsdev mentioned this pull request Jan 24, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ambeeeeee ambeeeeee ambeeeeee requested changes

Assignees
No one assigned
Labels
C-Code-Quality A section of code that is hard to understand or change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@joshuajbouw @cart @ambeeeeee @memoryruins