Assets: fix first hot reloading #9804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mockersf
added
the
A-Assets
alice-i-cecile
approved these changes
Oct 18, 2023
NiklasEi
approved these changes
Oct 25, 2023
There was a problem hiding this comment.
I can reproduce the issue and the fix in the asset_processor example.
One thing I noticed: with the fix, everything will be reloaded once after startup. I guess the processing is triggering some file event? But I would not block on that since it only happens the first time and is less of an issue compared to no hot reloading at all.
alice-i-cecile
added
the
S-Ready-For-Final-Review
cart
approved these changes
Oct 26, 2023
ameknite
pushed a commit
to ameknite/bevy
that referenced
this pull request
Nov 6, 2023
# Objective - Hot reloading doesn't work the first time it is used ## Solution - Currently, Bevy processor: 1. Create the `imported_assets` folder 2. Setup a watcher on it 3. Clear empty folders, so the `imported_assets` folder is deleted 4. Recreate the `imported_assets` folder and add all the imported assets - On a first run without an existing `imported_assets` with some content, hot reloading won't work as step 3 breaks the file watcher - This PR stops the empty root folder from being deleted - Also don't setup the processor internal asset server for file watching, freeing up a thread --------- Co-authored-by: Carter Anderson <[email protected]>
rdrpenguin04
pushed a commit
to rdrpenguin04/bevy
that referenced
this pull request
Jan 9, 2024
# Objective - Hot reloading doesn't work the first time it is used ## Solution - Currently, Bevy processor: 1. Create the `imported_assets` folder 2. Setup a watcher on it 3. Clear empty folders, so the `imported_assets` folder is deleted 4. Recreate the `imported_assets` folder and add all the imported assets - On a first run without an existing `imported_assets` with some content, hot reloading won't work as step 3 breaks the file watcher - This PR stops the empty root folder from being deleted - Also don't setup the processor internal asset server for file watching, freeing up a thread --------- Co-authored-by: Carter Anderson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Solution
imported_assetsfolderimported_assetsfolder is deletedimported_assetsfolder and add all the imported assetsimported_assetswith some content, hot reloading won't work as step 3 breaks the file watcher