Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Val into geometry #9818

Merged
merged 3 commits into from
Sep 15, 2023
Merged

Move Val into geometry #9818

merged 3 commits into from
Sep 15, 2023

Conversation

ickshonpe
Copy link
Contributor

@ickshonpe ickshonpe commented Sep 15, 2023 •
edited
Loading

Objective

Val's natural place is in the geometry module with UiRect, not in ui_node with the components.

Solution

Move Val into geometry.

@ickshonpe ickshonpe changed the title Move Val to geometry Move Val into geometry Sep 15, 2023
@alice-i-cecile alice-i-cecile added A-UI Graphical user interfaces, styles, layouts, and widgets C-Code-Quality A section of code that is hard to understand or change labels Sep 15, 2023
@alice-i-cecile
Copy link
Member

Doc links are broken (thanks CI). Once those are fixed, I'd like to merge this ASAP: code reorganization PRs are always brutal for merge conflcits.

@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Sep 15, 2023
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Sep 15, 2023
Merged via the queue into bevyengine:main with commit 462d2ff Sep 15, 2023
22 checks passed
rdrpenguin04 pushed a commit to rdrpenguin04/bevy that referenced this pull request Jan 9, 2024
@ickshonpe
Move Val into geometry (bevyengine#9818)
44df86f 
# Objective

`Val`'s natural place is in the `geometry` module with `UiRect`, not in
`ui_node` with the components.

## Solution 

Move `Val` into `geometry`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-UI Graphical user interfaces, styles, layouts, and widgets C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ickshonpe @alice-i-cecile