Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename num_font_atlases to len. #9879

Merged
merged 3 commits into from
Sep 20, 2023
Merged

Rename num_font_atlases to len. #9879

merged 3 commits into from
Sep 20, 2023

Conversation

ickshonpe
Copy link
Contributor

Objective

Rename the num_font_atlases method of FontAtlasSet to len.

All the function does is return the number of entries in its hashmap and the unnatural naming only makes it harder to discover.

Changelog

  • Renamed the num_font_atlases method of FontAtlasSet to len.

Migration Guide

The num_font_atlases method of FontAtlasSet has been renamed to len.

@alice-i-cecile alice-i-cecile added A-UI Graphical user interfaces, styles, layouts, and widgets C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide labels Sep 20, 2023
@james7132
Copy link
Member

Please add the corresponding is_empty that CI is asking for.

@james7132 james7132 added this pull request to the merge queue Sep 20, 2023
Merged via the queue into bevyengine:main with commit 9873c97 Sep 20, 2023
21 checks passed
rdrpenguin04 pushed a commit to rdrpenguin04/bevy that referenced this pull request Jan 9, 2024
@ickshonpe
Rename num_font_atlases to len. (bevyengine#9879)
e43e412 
# Objective

Rename the `num_font_atlases` method of `FontAtlasSet` to `len`.

All the function does is return the number of entries in its hashmap and
the unnatural naming only makes it harder to discover.

---

## Changelog

* Renamed the `num_font_atlases` method of `FontAtlasSet` to `len`.

## Migration Guide

The `num_font_atlases` method of `FontAtlasSet` has been renamed to
`len`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james7132 james7132 james7132 approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-UI Graphical user interfaces, styles, layouts, and widgets C-Usability A targeted quality-of-life change that makes Bevy easier to use M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ickshonpe @james7132 @alice-i-cecile