as_deref_mut() method for Mut-like types
#9912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I feel like |
|
I agree tbh, but I didn't think of it until the PR ready haha. Updated the PR. I didn't add an |
Testare
changed the title
set_deref_if_neq methodas_deref_mut() method for Mut-like types
JoJoJet
approved these changes
Sep 26, 2023
There was a problem hiding this comment.
I didn't add an as_deref method because there isn't really a point of a Mut that isn't mutable
I agree, a Ref variant is unnecessary. Similarly, we have map_unchanged for Mut but not for Ref. Generally there's just less of a need to map Ref since it doesn't trigger anything when dereferenced.
JoJoJet
approved these changes
Sep 26, 2023
JoJoJet
reviewed
Sep 29, 2023
Co-authored-by: Joseph <[email protected]>
alice-i-cecile
added
A-ECS
alice-i-cecile
approved these changes
Sep 29, 2023
|
Thank you both! 🙏 |
james7132
approved these changes
Oct 2, 2023
ameknite
pushed a commit
to ameknite/bevy
that referenced
this pull request
Oct 3, 2023
# Objective Add a new method so you can do `set_if_neq` with dereferencing components: `as_deref_mut()`! ## Solution Added an as_deref_mut method so that we can use `set_if_neq()` without having to wrap up types for derefencable components --------- Co-authored-by: Alice Cecile <[email protected]> Co-authored-by: Joseph <[email protected]>
ameknite
pushed a commit
to ameknite/bevy
that referenced
this pull request
Oct 3, 2023
# Objective Add a new method so you can do `set_if_neq` with dereferencing components: `as_deref_mut()`! ## Solution Added an as_deref_mut method so that we can use `set_if_neq()` without having to wrap up types for derefencable components --------- Co-authored-by: Alice Cecile <[email protected]> Co-authored-by: Joseph <[email protected]>
regnarock
pushed a commit
to regnarock/bevy
that referenced
this pull request
Oct 13, 2023
# Objective Add a new method so you can do `set_if_neq` with dereferencing components: `as_deref_mut()`! ## Solution Added an as_deref_mut method so that we can use `set_if_neq()` without having to wrap up types for derefencable components --------- Co-authored-by: Alice Cecile <[email protected]> Co-authored-by: Joseph <[email protected]>
rdrpenguin04
pushed a commit
to rdrpenguin04/bevy
that referenced
this pull request
Jan 9, 2024
# Objective Add a new method so you can do `set_if_neq` with dereferencing components: `as_deref_mut()`! ## Solution Added an as_deref_mut method so that we can use `set_if_neq()` without having to wrap up types for derefencable components --------- Co-authored-by: Alice Cecile <[email protected]> Co-authored-by: Joseph <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Add a new method so you can do
set_if_neqwith dereferencing components:as_deref_mut()!Solution
Added an as_deref_mut method so that we can use
set_if_neq()without having to wrap up types for derefencable components