Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI node outlines #9931

Merged
merged 15 commits into from
Oct 5, 2023
Merged

UI node outlines #9931

merged 15 commits into from
Oct 5, 2023

Commits on Sep 26, 2023

  1. Adds support for outlines to Bevy UI. 

    * The `Outline` component adds an outline to a UI Node.
* The `outline_width` field added to `Node` holds the resolved width of the outline, which is set by the `resolve_outlines_system` after layout recomputation.
* Outlines are drawn by the system `extract_uinode_outlines`.
    @ickshonpe
    ickshonpe committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    939411e View commit details
    Browse the repository at this point in the history

  2. Use &Outline query not Ref<Outline> in resolve_outlines_system

    @ickshonpe
    ickshonpe committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    f2a5595 View commit details
    Browse the repository at this point in the history

  3. Outline width should be resolved with max(0) not min(0).

    @ickshonpe
    ickshonpe committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    0e82b9e View commit details
    Browse the repository at this point in the history

  4. Implement clipping for outlines. Outlines are drawn outside out of a … 

    …node's border, so they are clipped using the clipping Rect of their ui node entity's parent.
    @ickshonpe
    ickshonpe committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    53a5e9f View commit details
    Browse the repository at this point in the history

  5. cargo fmt --all

    @ickshonpe
    ickshonpe committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    cbdbf85 View commit details
    Browse the repository at this point in the history

  6. Fixed broken doc comment link

    @ickshonpe
    ickshonpe committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    0d9df14 View commit details
    Browse the repository at this point in the history

  7. replaced map-flatten with and_then in extract_uinode_outlines

    @ickshonpe
    ickshonpe committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    677dcda View commit details
    Browse the repository at this point in the history

  8. removed unnecessary semicolon

    @ickshonpe
    ickshonpe committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    472c14f View commit details
    Browse the repository at this point in the history

  9. Allow Outlines to be drawn with an offset: 

    * Added an `outline_offset: f32` field to Node.
* Added an `offset: Val` field to `Outline`.
* In `extract_uinode_outlines` the twice the outline offset is added to the node size before calculating
    @ickshonpe
    ickshonpe committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    fd63961 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2023

  1. added examples to the doc comments for Outline

    @ickshonpe
    ickshonpe committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    a01e290 View commit details
    Browse the repository at this point in the history

  2. edit comments

    @ickshonpe
    ickshonpe committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    975813b View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into ui-node-outlines

    @ickshonpe
    ickshonpe committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    7bf07c7 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2023

  1. fixed doc comment example errors

    @ickshonpe
    ickshonpe committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    39b390e View commit details
    Browse the repository at this point in the history

  2. fixed doc comments

    @ickshonpe
    ickshonpe committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    8cd8e55 View commit details
    Browse the repository at this point in the history

  3. comments fixed again

    @ickshonpe
    ickshonpe committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    32c6c09 View commit details
    Browse the repository at this point in the history