Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swapping between routes very quickly crashes the Vue renderer #61

Closed
Jazcash opened this issue Sep 3, 2022 · 6 comments
Closed

Swapping between routes very quickly crashes the Vue renderer #61

Jazcash opened this issue Sep 3, 2022 · 6 comments
Labels
bug Something isn't working

Comments

@Jazcash
Copy link
Member

Jazcash commented Sep 3, 2022 

Failed to execute 'insertBefore' on 'Node': The node before which the new node is to be inserted is not a child of this node.

Seems easier to repro on multiplayer custom battle list page, possibly related to suspense api
@Jazcash Jazcash added the bug Something isn't working label Sep 3, 2022
@Jazcash
Copy link
Member Author

Jazcash commented Sep 3, 2022 •
edited
Loading

https://lightrun.com/answers/nuxt-framework-error-when-fast-navigating-failed-to-execute-insertbefore-on-node

vuejs/core#5513

@Jazcash
Copy link
Member Author

Jazcash commented Mar 30, 2023 •
edited
Loading

Possibly related to vuejs/core#7966 (comment)

#179

@1-alex98
Copy link
Contributor

vuejs/core#8105

@1-alex98
Copy link
Contributor

Removing transition removes the issue

bar-lobby/src/renderer/App.vue

Line 32 in b2f3b1e

<transition mode="out-in" name="slide-left">

@1-alex98
Copy link
Contributor

Maybe we should do that until issue is fixed in vue or we have a better solution

@1-alex98
Copy link
Contributor

Also removing out-in works. Does not look as good tho

1-alex98 added a commit to 1-alex98/bar-lobby that referenced this issue Jun 11, 2023
@1-alex98
Remove transition mode out-in
ad93dc6 
Prepares beyond-all-reason#61
@1-alex98 1-alex98 mentioned this issue Jun 11, 2023
Merged
1-alex98 added a commit to 1-alex98/bar-lobby that referenced this issue Jun 16, 2023
@1-alex98
Remove transition mode out-in
8a9b592 
Prepares beyond-all-reason#61
1-alex98 added a commit to 1-alex98/bar-lobby that referenced this issue Jun 16, 2023
@1-alex98
Merge branch 'bugfix/beyond-all-reason#61-remove-transition' of https…
bcd6053 
…://github.com/1-alex98/bar-lobby into bugfix/beyond-all-reason#61-remove-transition
Jazcash added a commit that referenced this issue Aug 31, 2023
@Jazcash
Merge pull request #230 from 1-alex98/bugfix/#61-remove-transition
63d9b24 
Remove transition mode out-in
@Jazcash Jazcash mentioned this issue Oct 14, 2023
Closed
Mark104 pushed a commit to Mark104/bar-lobby that referenced this issue Sep 25, 2024
@MarkDawson104
Updated Vue version to latest (as contains part of a fix for transiti…
0b61ebb 
…on issue in beyond-all-reason#61 & beyond-all-reason#179 & beyond-all-reason#248).  Moved await in ranked setup to onMounted and added opt-in back in.

Seems to me that also a part of this is that we're awaiting in component setups. Far as I understand the lifecycle, we should be using onMounted to do such things or rather maybe Vue prefers we do.
@Mark104 Mark104 mentioned this issue Sep 25, 2024
Closed
@bcdrme bcdrme closed this as completed Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Jazcash @1-alex98 @bcdrme