Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Scored Spads Battle Data #246

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Refactor Scored Spads Battle Data #246

wants to merge 3 commits into from

Conversation

JasonReed-2
Copy link
Contributor

Fixes #245

@JasonReed-2 JasonReed-2 changed the title Add AbstractClass discriminator for better runtime typechecking draft: Add AbstractClass discriminator for better runtime typechecking Sep 6, 2023
@JasonReed-2 JasonReed-2 changed the title draft: Add AbstractClass discriminator for better runtime typechecking Add AbstractClass discriminator for better runtime typechecking Sep 7, 2023
@JasonReed-2 JasonReed-2 marked this pull request as draft September 7, 2023 02:24
@JasonReed-2 JasonReed-2 changed the title Add AbstractClass discriminator for better runtime typechecking Refactor Scored Spads Battle Data Sep 7, 2023
@JasonReed-2
Copy link
Contributor Author

After discussing: the better approach to fixing #245 is to have the battles in the list remain as SpadsBattle objects that contain the methods of the parent classes.

@JasonReed-2 JasonReed-2 marked this pull request as ready for review September 7, 2023 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BattlePreview has fatal error due to not recognizing scored battles as abstract battles.
1 participant
@JasonReed-2