When Informer misses the delete event, on resync it does not clear th… #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e stored status correctly with system rather it keeps it around forever, the changes in this commit will do temoprary fix to delete the Informer local cache pending the fabric8 issue fabric8io/kubernetes-client#2994
rareddy
requested review from
ppatierno and
shawkins
and removed request for
ppatierno
|
//cc @ppatierno @k-wall |
k-wall
reviewed
Apr 15, 2021
k-wall
reviewed
Apr 15, 2021
sync/src/main/java/org/bf2/sync/informer/CustomResourceEventHandler.java
Show resolved
Hide resolved
k-wall
reviewed
Apr 15, 2021
operator/src/main/java/org/bf2/operator/events/ResourceEventSource.java
Outdated
Show resolved
Hide resolved
k-wall
approved these changes
Apr 16, 2021
ppatierno
approved these changes
Apr 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e stored status correctly with system rather it keeps it around forever, the changes in this commit will do temoprary fix to delete the Informer local cache pending the fabric8 issue fabric8io/kubernetes-client#2994