Update XS001 and XR005 to allow more ways of setting Description #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bflad
added
ast
bflad
approved these changes
Jul 20, 2021
There was a problem hiding this comment.
Looks good to me, thank you for raising these issues and contributing these fixes. 🚀 We may want these checks to still disallow "" (empty string) if a string literal is provided, however the tests were not covering this and not sure if folks are dependent on that particular edge case.
bflad
added a commit
that referenced
this pull request
Jul 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #240
fixes #241
Reduces false positives by checking for field existence instead of string value.