fix v4/v6 as2rel issue #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Found a bug that is likely related to this issue: * The as2rel inference needs to run 2 times, updating 3 different HashMaps for global, and v4 or v6 data map * The function takes a mutable AS path vector as it examines the reverse of the path (i.e. from origin to collector) * The second time the function runs, the AS path is already reversed as input and thus causing the program at different AS paths * The first run is for the global relationship, which corresponds to the `as2rel-latest` data file. It makes sense that the `as2rel-latest` looks correct, while the v4/v6 ones look strange.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a bug that is likely related to #7:
as2rel-latestdata file. It makes sense that theas2rel-latestlooks correct, while the v4/v6 ones look strange.