#24-backend-imp-crud-for-users-model #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…enamed auth to user repo and files
…4-backend-imp-crud-feature-create-profile
…e: add develop docker-compose to work out
…-crud-for-users-model
…orrect names, structure, imports
…ions and correct verify_jwt exceptions, get_current_user exceptions and change return
…-crud-feature-create-profile
…all models with new redis pub/sub communicator
…ub/sub for models
… profile service and communicate with user
…e for change_password_view
radthenone
requested review from
f-lapinski,
KarolBautrel,
kwiats,
maciej-MKan,
MarcinBinkowski and
MarcinNiemczyk
KarolBautrel
reviewed
Mar 3, 2024
KarolBautrel
reviewed
Mar 3, 2024
KarolBautrel
reviewed
Mar 3, 2024
KarolBautrel
reviewed
Mar 3, 2024
KarolBautrel
reviewed
Mar 3, 2024
KarolBautrel
reviewed
Mar 3, 2024
KarolBautrel
reviewed
Mar 3, 2024
KarolBautrel
reviewed
Mar 3, 2024
KarolBautrel
reviewed
Mar 3, 2024
kwiats
reviewed
Mar 3, 2024
…ofiles this created in media urls
…sers do it with relations and profile image is not needed here
|
Ok its corrected and can be push |
…4-backend-imp-crud-for-users-model
kwiats
reviewed
Mar 17, 2024
…oved abs from init cache handler, router remove unused import
…ved abs from init cache handler, router remove unused import
…del' into 24-backend-imp-crud-for-users-model
…oved abs from init cache handler, router remove unused import
…del' into 24-backend-imp-crud-for-users-model
kwiats
approved these changes
Mar 22, 2024
| None | ||
| """ | ||
| def __init__(self, pool_storage: ICacheStorage): | ||
| self.pool = pool_storage |
Comment on lines
10
to
13
| class ICacheHandler(ABC): | ||
| @abstractmethod | ||
| def __init__(self, pool_storage: "ICacheStorageType"): | ||
| pass |
There was a problem hiding this comment.
Why you define constructor in interface???
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Auth, User, Profile crud with, storages, and pub/sub changes