#108-implement-soft-delete-mechanism-for-media #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…default delay 0.2s
…rofile services, one prepare image to add and update, second delete profile image. Image formats are in jpeg format only in minio. But accepts all images standards
…ad app processes and create simple add_task method to delay image remove by 30min
…ded to cloud storage minio
kwiats
reviewed
Mar 9, 2024
backend/src/common/utils.py
Outdated
| logger = logging.getLogger(__name__) | ||
|
|
||
|
|
||
| def delay_time(time_string="0.2s"): |
There was a problem hiding this comment.
you should add docstring there
Comment on lines
21
to
26
| def delayed_task(): | ||
| if delay: | ||
| delay_time(delay) | ||
| func(*args, **kwargs) | ||
|
|
||
| make_thread(delayed_task) |
There was a problem hiding this comment.
What if we add a new feature and we need to rebuild our server? The delay will disappear. We need to save the timestamp of deletion and check it in a separate task. This is my idea.
KarolBautrel
approved these changes
Mar 25, 2024
radthenone
added
Backend
Signed-off-by: MaciejKan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.