Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix MSRV build by precisely specifying some deps. #731

Merged
merged 3 commits into from
Oct 15, 2023

Conversation

waywardmonkeys
Copy link
Contributor

No description provided.

@waywardmonkeys
Copy link
Contributor Author

This also stops the build from cancelling all jobs once one fails, so that we can see the results for each version of Rust tested. Otherwise, the stable job fails (due to clippy) and we don't get results for the MSRV build.

@waywardmonkeys
Copy link
Contributor Author

#729 fixes the stable build and can be rebased forward and land once this one does.

@lemmih
Copy link
Collaborator

lemmih commented Oct 14, 2023

How about joining the two PRs? I'd feel much better about merging a PR that passes all the checks.

@waywardmonkeys
Copy link
Contributor Author

@lemmih Okay, I've added the single commit here that should fix the current clippy build. The other PR contains further changes that go beyond just fixing the build.

@lemmih lemmih merged commit e2de721 into bheisler:master Oct 15, 2023
4 checks passed
@waywardmonkeys waywardmonkeys deleted the fix-msrv-build branch October 15, 2023 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants