-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manifest v3 #215
Manifest v3 #215
Conversation
import tseslint from "typescript-eslint"; | ||
|
||
export default tseslint.config( | ||
{ name: "eslint/recommended", ...eslint.configs.recommended }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Expected ')' and instead saw 'eslint'.
Expected '}' to match '{' from line 10 and instead saw '...'.
Missing semicolon.
Unrecoverable syntax error. (4% scanned).
import globals from "globals"; | ||
import tseslint from "typescript-eslint"; | ||
|
||
export default tseslint.config( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'export' is only available in ES6 (use 'esversion: 6').
import github from "eslint-plugin-github"; | ||
import sonarjs from "eslint-plugin-sonarjs"; | ||
import globals from "globals"; | ||
import tseslint from "typescript-eslint"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'import' is only available in ES6 (use 'esversion: 6').
import arrayFunc from "eslint-plugin-array-func"; | ||
import github from "eslint-plugin-github"; | ||
import sonarjs from "eslint-plugin-sonarjs"; | ||
import globals from "globals"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'import' is only available in ES6 (use 'esversion: 6').
import eslint from "@eslint/js"; | ||
import arrayFunc from "eslint-plugin-array-func"; | ||
import github from "eslint-plugin-github"; | ||
import sonarjs from "eslint-plugin-sonarjs"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'import' is only available in ES6 (use 'esversion: 6').
import { fixupPluginRules } from "@eslint/compat"; | ||
import eslint from "@eslint/js"; | ||
import arrayFunc from "eslint-plugin-array-func"; | ||
import github from "eslint-plugin-github"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'import' is only available in ES6 (use 'esversion: 6').
@@ -0,0 +1,209 @@ | |||
import { fixupPluginRules } from "@eslint/compat"; | |||
import eslint from "@eslint/js"; | |||
import arrayFunc from "eslint-plugin-array-func"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'import' is only available in ES6 (use 'esversion: 6').
@@ -0,0 +1,209 @@ | |||
import { fixupPluginRules } from "@eslint/compat"; | |||
import eslint from "@eslint/js"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'import' is only available in ES6 (use 'esversion: 6').
@@ -0,0 +1,209 @@ | |||
import { fixupPluginRules } from "@eslint/compat"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'import' is only available in ES6 (use 'esversion: 6').
This switches JSONView to the "Manifest V3" APIs. Unfortunately, this is a more restrictive set of APIs, so some features have been removed (namely, access to the JSON data in the console). I also now have to build slightly different packages for Firefox and Chrome-based browsers, as they differ in what they support.
I also fixed a couple other issues while I was in there.