"&" html entity in the name of the testcase became "&" if is followed by a ";" not preceded by a "&" (xmlbuilder2 issue)

[Laurianti]

Hello, this is a strange case:

This is the combined output:

I think this is an issue of the xmlbuilder2 library.
oozcitak/xmlbuilder2#109

[bhovhannes]

Hello, you are right, this should be fixed in xmlbuilder2.

Renovate is enabled in this repo, so as soon a new version of xmlbuilder2 will be released I'll bump version here.

[ggrossetie]

I can reproduce this: michaelleeallen/mocha-junit-reporter#181

[ggrossetie]

@bhovhannes we've created a fork to fix this issue: https://www.npmjs.com/package/@datagalaxy/xmlbuilder2

Here's the full diff:

oozcitak/xmlbuilder2@master...datagalaxy-lab:xmlbuilder2:master

The minimum Node version is now 14 and we've also upgraded the dependencies to the latest version.
Ozgur Ozcitak (oozcitak) is not really active anymore on GitHub so I'm not sure if xmlbuilder2 will receive any update.

Let me know if you are willing to switch to our fork 😉

[bhovhannes]

I added a failing test case for this issue and downgraded xmlbuilder2 dependency to 3.0.1. With 3.0.1 test passed.
It looks like from 3.0.1 to 3.0.2 Ozgur closed oozcitak/xmlbuilder2#99 and comments under that issue are not convincing that it was indeed fixed.

@ggrossetie I'll keep an eye on your fork and will consider switching to it once it will get more traction. I think fork will get more traction if

• you refer to it in Encoding issue when & html entity is followed by a ";" not preceded by a "&". oozcitak/xmlbuilder2#109 and & written instead of & oozcitak/xmlbuilder2#110. There are number of other encoding issues in xmlbuilder2 and maybe some of them will be fixed by your commit in your fork as well. When people will notice that there is a fork which tries to fix something they will try if the fork works in their use case.
• update fork Readme to mention that it is the fork and describe the reasoning behind creating a fork.

[universalhandle]

Greetings! I arrived here from a link in the official xmlbuilder2 repo. I've just joined that project as a new maintainer. From a quick read I think the issues raised here are fixed in oozcitak/xmlbuilder2#154.

I'm still working on getting maintainer status in npm; as soon as I have that I'll ship the fix in question. I hope we can coalesce around the official package rather than end up with various forks -- I'm very open to collaboration. Cheers!

[ggrossetie]

That's great to hear!
The latest version of junit-report-merger is working great for us and if xmlbuilder2 has now an active maintainer then there's no reason to maintain our own fork.