fix(closes #127): downgrade xmlbuilder2 dependency to 3.0.1

bhovhannes · Feb 19, 2023 · 93bd8bc · 93bd8bc
1 parent 521249d
commit 93bd8bc
Show file tree

Hide file tree

Showing 4 changed files with 28 additions and 10 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -23,7 +23,7 @@
   "dependencies": {
     "commander": "~10.0.0",
     "fast-glob": "~3.2.11",
-    "xmlbuilder2": "~3.0.2"
+    "xmlbuilder2": "3.0.1"
   },
   "repository": {
     "type": "git",

diff --git a/test/e2e.spec.js b/test/e2e.spec.js
@@ -128,6 +128,18 @@ describe('e2e', function () {
       expect(contents).toContain('failure message with ]]&gt;')
     })
 
+    it('preserves xml entities in attributes', async () => {
+      await mergeFiles(
+        fixturePaths.output,
+        [path.join(__dirname, 'fixtures', 'with-entities-in-attributes.xml')],
+        {}
+      )
+
+      const contents = await fsPromises.readFile(fixturePaths.output, 'utf8')
+      expect(contents).toContain('SingleSemicolon(&amp;)')
+      expect(contents).toContain('DoubleSemicolon(&amp;;)')
+    })
+
     it('merges m*.xml files into one, matching predefined snapshot', async () => {
       await mergeFiles(fixturePaths.output, fixturePaths.inputs)
       const actualContents = await fsPromises.readFile(fixturePaths.output, 'utf8')

diff --git a/test/fixtures/with-entities-in-attributes.xml b/test/fixtures/with-entities-in-attributes.xml
@@ -0,0 +1,7 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<testsuite xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="https://maven.apache.org/surefire/maven-surefire-plugin/xsd/surefire-test-report.xsd"
+           name="repro.MyTest" time="2.6" tests="1" errors="0" skipped="0" failures="1">
+    <properties/>
+    <testcase name="SingleSemicolon(&amp;)"/>
+    <testcase name="DoubleSemicolon(&amp;;)"/>
+</testsuite>