Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vertical scrolling of descriptions #134

Merged
merged 2 commits into from
Jul 4, 2020
Merged

Fix vertical scrolling of descriptions #134

merged 2 commits into from
Jul 4, 2020

Conversation

zothynine
Copy link
Contributor

This commit is a bugfix for the issue #130 in CSS. The description text was not scrollable when on left, right or bottom position. I added this CSS:

.gslide-description {
    max-height: 100vh;
    overflow-y: auto;
    …
}

I sadly could not test this on IE11, since I'm working on a Mac,sorry!

@biati-digital
Copy link
Owner

Thank you for the pull request, i think the bug it's more complex than the provided solution, the content should not be bigger than the image, it should maintain the same height as the image and resize accordingly.

Descriptions shon besides media can not be higher as the media
@zothynine
Copy link
Contributor Author

Thank you for your quick response. I made a second commit in this branch that addresses the height problem. Please review my changes and tell me if they are OK.

Greetings from Vienna, Mario

@biati-digital
Copy link
Owner

Awesome, seems to be working fine. Thank you for taking the time to fix this.

@biati-digital biati-digital merged commit db8e176 into biati-digital:master Jul 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants