Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source code to reproduce miniboxed stream numbers #1

Merged
merged 1 commit into from
Dec 1, 2014

Conversation

VladUreche
Copy link
Contributor

The only significant change is the addition of the Numeric trait
that is required for obtaining the best performance (it cuts down
the benchmark time by 50-100%). The rest is just the same source
code, modulo some whitespace my editor f'd up.

The Numeric issue is tracked here:
miniboxing/miniboxing-plugin#154

And the numbers I got were:

[info] Benchmark                                        Mode  Samples    Score    Error  Units
[info] b.StreamsBenchmarks.baseline_cart                avgt        5    5.202 ±  0.544  ms/op
[info] b.StreamsBenchmarks.baseline_ref                 avgt        5   29.927 ±  6.279  ms/op
[info] b.StreamsBenchmarks.baseline_sum                 avgt        5    6.628 ±  2.986  ms/op
[info] b.StreamsBenchmarks.baseline_sumOfSquares        avgt        5    7.164 ±  1.254  ms/op
[info] b.StreamsBenchmarks.baseline_sumOfSquaresEven    avgt        5   12.746 ±  1.243  ms/op
[info] b.StreamsBenchmarks.streams_cart                 avgt        5   55.321 ± 12.771  ms/op
[info] b.StreamsBenchmarks.streams_ref                  avgt        5   63.508 ± 12.324  ms/op
[info] b.StreamsBenchmarks.streams_sum                  avgt        5   12.017 ±  0.879  ms/op
[info] b.StreamsBenchmarks.streams_sumOfSquares         avgt        5   12.977 ±  0.670  ms/op
[info] b.StreamsBenchmarks.streams_sumOfSquaresEven     avgt        5   52.159 ± 32.626  ms/op
[info] b.StreamsBenchmarks.views_cart                   avgt        5  314.893 ± 64.045  ms/op
[info] b.StreamsBenchmarks.views_ref                    avgt        5  157.288 ± 15.642  ms/op
[info] b.StreamsBenchmarks.views_sum                    avgt        5   83.296 ± 19.200  ms/op
[info] b.StreamsBenchmarks.views_sumOfSquares           avgt        5  200.816 ± 75.311  ms/op
[info] b.StreamsBenchmarks.views_sumOfSquaresEven       avgt        5  221.260 ± 13.161  ms/op

Review by @biboudis, hope you like it :)

The only significant change is the addition of the Numeric trait
that is required for obtaining the best performance (it cuts down
the benchmark time by 50-100%). The rest is just the same source
code, modulo some whitespace my editor f'd up.

The Numeric issue is tracked here:
miniboxing/miniboxing-plugin#154

And the numbers I got were:
```

[info] Benchmark                                        Mode  Samples    Score    Error  Units
[info] b.StreamsBenchmarks.baseline_cart                avgt        5    5.202 ±  0.544  ms/op
[info] b.StreamsBenchmarks.baseline_ref                 avgt        5   29.927 ±  6.279  ms/op
[info] b.StreamsBenchmarks.baseline_sum                 avgt        5    6.628 ±  2.986  ms/op
[info] b.StreamsBenchmarks.baseline_sumOfSquares        avgt        5    7.164 ±  1.254  ms/op
[info] b.StreamsBenchmarks.baseline_sumOfSquaresEven    avgt        5   12.746 ±  1.243  ms/op
[info] b.StreamsBenchmarks.streams_cart                 avgt        5   55.321 ± 12.771  ms/op
[info] b.StreamsBenchmarks.streams_ref                  avgt        5   63.508 ± 12.324  ms/op
[info] b.StreamsBenchmarks.streams_sum                  avgt        5   12.017 ±  0.879  ms/op
[info] b.StreamsBenchmarks.streams_sumOfSquares         avgt        5   12.977 ±  0.670  ms/op
[info] b.StreamsBenchmarks.streams_sumOfSquaresEven     avgt        5   52.159 ± 32.626  ms/op
[info] b.StreamsBenchmarks.views_cart                   avgt        5  314.893 ± 64.045  ms/op
[info] b.StreamsBenchmarks.views_ref                    avgt        5  157.288 ± 15.642  ms/op
[info] b.StreamsBenchmarks.views_sum                    avgt        5   83.296 ± 19.200  ms/op
[info] b.StreamsBenchmarks.views_sumOfSquares           avgt        5  200.816 ± 75.311  ms/op
[info] b.StreamsBenchmarks.views_sumOfSquaresEven       avgt        5  221.260 ± 13.161  ms/op
```
@VladUreche
Copy link
Contributor Author

@biboudis, do you mind if we make scala-streams a case study on the miniboxing website?

@biboudis
Copy link
Owner

biboudis commented Dec 1, 2014

Not at all @VladUreche, feel free to add it on the miniboxing website. You have my full support.

@biboudis
Copy link
Owner

biboudis commented Dec 1, 2014

Before merging it @VladUreche a naive question: don't you mind that I have annotated with specialized and not with miniboxed? Shouldn't we use @miniboxed?

@VladUreche
Copy link
Contributor Author

@biboudis: No, no problem at all. -P:minibox:mark-all will wipe @specialized and make it @miniboxed anyway :D

@VladUreche
Copy link
Contributor Author

Not at all @VladUreche, feel free to add it on the miniboxing website. You have my full support.

Well, we'll need to write this together. But not now, there are more important matters.

biboudis added a commit that referenced this pull request Dec 1, 2014
Source code to reproduce miniboxed stream numbers.
@biboudis biboudis merged commit 5763696 into biboudis:master Dec 1, 2014
@VladUreche
Copy link
Contributor Author

👍

@biboudis
Copy link
Owner

biboudis commented Dec 1, 2014

Although I like the annotation to be specified explicitly so I will update
it. ;-)

@VladUreche
Copy link
Contributor Author

Knock yourself out :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants