Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rewrite README and repo transfer to BIDS-spec #21

Closed
3 tasks done
remiadon opened this issue Jul 30, 2020 · 13 comments
Closed
3 tasks done

rewrite README and repo transfer to BIDS-spec #21

remiadon opened this issue Jul 30, 2020 · 13 comments
Assignees

Comments

@remiadon
Copy link
Contributor

remiadon commented Jul 30, 2020

rewrite taking https://github.com/bids-standard/bep001 as example

@remiadon
Copy link
Contributor Author

remiadon commented Jul 30, 2020

@cmaumet I just updated the readme

Main differences with the bep001 version

  • No Finding information and getting in touch section for the moment, we don't have any mailist list, nor montly mettings
  • an additional BIDS-prov in the NIDM project sub-section, to be removed if this is your will. I thought this gives more context

@cmaumet
Copy link
Collaborator

cmaumet commented Jul 30, 2020

@remiadon - Thanks! About "Finding info and getting in touch" -- could we use at least for now the NIDM group as entry point --> https://github.com/incf-nidash/nidm-specs/#nidm-weekly-calls

@remiadon
Copy link
Contributor Author

Of course

I forgot to mention something important
We have no Proposed changes to specification (along with a dedicated .md file), see here

@cmaumet
Copy link
Collaborator

cmaumet commented Jul 31, 2020

@remiadon Thanks for this update. I only have a few suggestions:

  • "Who is building BEP028" can you add all the contributors we had listed in [WIP] [ENH] Provenance BEP028 bids-specification#439 (all of these people contributed to the first draft)
  • I'd remove "Avoiding great big pull requests" for now -- not sure this is quite the way we will work. Maybe replace by "How to ask a question / propose a change in BIDS PROV" and mention that people can submit issues to start the discussion and then join the calls.
  • I'd add a link to where the spec can be viewed (currently the google doc)
  • Add credit at the bottom of the README saying that it was inspired by the BEP001 readme.

@cmaumet
Copy link
Collaborator

cmaumet commented Jul 31, 2020

We have no Proposed changes to specification (along with a dedicated .md file), see here

Isn't this the role of the https://github.com/Inria-Visages/BIDS-prov/blob/master/new_features.md file? If so, how about linking to this from the "How to ask a question / propose a change in BIDS PROV" section?

@remiadon
Copy link
Contributor Author

@cmaumet yes exactly, just was wondering if this is the right name

@cmaumet
Copy link
Collaborator

cmaumet commented Jul 31, 2020

I see! Yes, using the same name would make sense, although in our case those are more points that will have to be discussed (as opposed to features we agreed to submit to the main spec).

@remiadon remiadon added Community embedding Meeting with neuroimaging community community-contrib and removed Community embedding Meeting with neuroimaging community labels Aug 4, 2020
@cmaumet cmaumet changed the title rewrite README rewrite README and repo transfer to BIDS-spec Aug 4, 2020
@cmaumet
Copy link
Collaborator

cmaumet commented Sep 8, 2020

Hey @remiadon, welcome back! If you can look into #21 (comment), then I'll ask for the repo to be moved under the BIDS organization.

@remiadon remiadon self-assigned this Sep 10, 2020
@remiadon
Copy link
Contributor Author

@cmaumet see 545abf3 :)

@remiadon
Copy link
Contributor Author

@cmaumet everything seems OK on my side

@cmaumet
Copy link
Collaborator

cmaumet commented Sep 11, 2020

Thanks @remiadon! Could you add JB Poline as well? (He is listed in the top comment here as he contributed to the google doc - bids-standard/bids-specification#439 (comment))

@remiadon
Copy link
Contributor Author

@cmaumet DONE

@cmaumet
Copy link
Collaborator

cmaumet commented Sep 15, 2020

Done: https://github.com/bids-standard/BEP028_BIDSprov

@cmaumet cmaumet closed this as completed Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants