Merge pull request #30 from bids-standard/master

update 9/3
bids-standard · Sep 4, 2019 · de3649c · de3649c
2 parents a8f1cbe + 4c39c10
commit de3649c
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 3 deletions.
diff --git a/src/04-modality-specific-files/03-electroencephalography.md b/src/04-modality-specific-files/03-electroencephalography.md
@@ -57,6 +57,8 @@ also encourage users to provide additional meta information extracted from the
 manufacturer specific data files in the sidecar JSON file. Other relevant files
 MAY be included alongside the original EEG data in `/sourcedata`.
 
+Note the RecordingType, which depends on whether the data stream on disk is interrupted or not. Continuous data is by definition 1 segment without interruption. Epoched data consists of multiple segments that all have the same length (e.g., corresponding to trials) and that have gaps in between. Discontinuous data consists of multiple segments of different length, for example due to a pause in the acquisition.
+
 Note that for proper documentation of EEG recording metadata it is important to
 understand the difference between electrode and channel: An EEG electrode is
 attached to the skin, whereas a channel is the combination of the analog
@@ -130,7 +132,7 @@ SHOULD be present:
 | MiscChannelCount           | RECOMMENDED. Number of miscellaneous analog channels for auxiliary signals.                                                                                                                                                                                                                                    |
 | TriggerChannelCount        | RECOMMENDED. Number of channels for digital (TTL bit level) trigger.                                                                                                                                                                                                                                           |
 | RecordingDuration          | RECOMMENDED. Length of the recording in seconds (e.g., 3600).                                                                                                                                                                                                                                                  |
-| RecordingType              | RECOMMENDED. Defines whether the recording is `continuous` or `epoched`.                                                                                                                                                                                                                                       |
+| RecordingType              | RECOMMENDED. Defines whether the recording is `continuous`, `discontinuous`  or `epoched`.                                                                                                                                                                                                                     |
 | EpochLength                | RECOMMENDED. Duration of individual epochs in seconds (e.g., 1) in case of epoched data.                                                                                                                                                                                                                       |
 | HeadCircumference          | RECOMMENDED. Circumference of the participants head, expressed in cm (e.g., 58).                                                                                                                                                                                                                               |
 | EEGPlacementScheme         | RECOMMENDED. Placement scheme of EEG electrodes. Either the name of a standardized placement system (e.g., "10-20") or a list of standardized electrode names (e.g., `["Cz", "Pz"]`).                                                                                                                          |

diff --git a/src/04-modality-specific-files/04-intracranial-electroencephalography.md b/src/04-modality-specific-files/04-intracranial-electroencephalography.md
@@ -65,6 +65,8 @@ additional meta information extracted from the manufacturer-specific data files
 in the sidecar JSON file. Other relevant files MAY be included alongside the
 original iEEG data in the [`/sourcedata` directory](../02-common-principles.md#source-vs-raw-vs-derived-data).
 
+Note the RecordingType, which depends on whether the data stream on disk is interrupted or not. Continuous data is by definition 1 segment without interruption. Epoched data consists of multiple segments that all have the same length (e.g., corresponding to trials) and that have gaps in between. Discontinuous data consists of multiple segments of different length, for example due to a pause in the acquisition.
+
 ### Terminology: Electrodes vs. Channels
 
 For proper documentation of iEEG recording metadata it is important to
@@ -147,8 +149,8 @@ Specific iEEG fields SHOULD be present:
 | MiscChannelCount                | RECOMMENDED. Number of miscellaneous analog channels for auxiliary signals.                                                                                                                                                                                                                                    |
 | TriggerChannelCount             | RECOMMENDED. Number of channels for digital (TTL bit level) triggers.                                                                                                                                                                                                                                          |
 | RecordingDuration               | RECOMMENDED. Length of the recording in seconds (e.g., 3600).                                                                                                                                                                                                                                                  |
-| RecordingType                   | RECOMMENDED. Defines whether the recording is "continuous" or "epoched"; this latter limited to time windows about events of interest (e.g., stimulus presentations, subject responses etc.)                                                                                                                   |
-| EpochLength                     | RECOMMENDED. Duration of individual epochs in seconds (e.g., 1) in case of epoched data. If recording was continuous, leave out the field.                                                                                                                                                                     |
+| RecordingType                   | RECOMMENDED. Defines whether the recording is "continuous", "discontinuous" or "epoched"; this latter limited to time windows about events of interest (e.g., stimulus presentations, subject responses etc.)                                                                                                  |
+| EpochLength                     | RECOMMENDED. Duration of individual epochs in seconds (e.g., 1) in case of epoched data. If recording was continuous or discontinuous, leave out the field.                                                                                                                                                    |
 | iEEGGround                      | RECOMMENDED. Description of the location of the ground electrode ("placed on right mastoid (M2)").                                                                                                                                                                                                             |
 | iEEGPlacementScheme             | RECOMMENDED. Freeform description of the placement of the iEEG electrodes. Left/right/bilateral/depth/surface (e.g., "left frontal grid and bilateral hippocampal depth" or "surface strip and STN depth" or "clinical indication bitemporal, bilateral temporal strips and left grid").                       |
 | iEEGElectrodeGroups             | RECOMMENDED. Field to describe the way electrodes are grouped into strips, grids or depth probes e.g., {'grid1': "10x8 grid on left temporal pole", 'strip2': "1x8 electrode strip on xxx"}.                                                                                                                   |

diff --git a/src/99-appendices/01-contributors.md b/src/99-appendices/01-contributors.md
@@ -127,6 +127,7 @@ your name is not listed, please add it.
 -   Andrea Pigorini 📖
 -   Russell A. Poldrack 📖🔍📢
 -   Jean-Baptiste Poline 📖📢🤔🎨
+-   Wouter V. Potters 📖
 -   Nader Pouratian 📖
 -   Pradeep Reddy Raamana 💻🔧
 -   Vasudev Raguram 💻🎨📖🔧

diff --git a/src/CHANGES.md b/src/CHANGES.md
@@ -7,6 +7,7 @@ Changelog
 -   \[ENH] Release protocol notes [#304](https://github.com/bids-standard/bids-specification/pull/304) ([franklin-feingold](https://github.com/franklin-feingold))
 -   REL: 1.3.0-dev [#303](https://github.com/bids-standard/bids-specification/pull/303) ([franklin-feingold](https://github.com/franklin-feingold))
 -   \[INFRA] Adding contributor appendix sentence to PR template  [#299](https://github.com/bids-standard/bids-specification/pull/299) ([franklin-feingold](https://github.com/franklin-feingold))
+-   \[ENH] Added discontinuous datatype for EEG and iEEG [#286](https://github.com/bids-standard/bids-specification/pull/286) ([wouterpotters](https://github.com/wouterpotters))
 
 ## [v1.2.1](https://github.com/bids-standard/bids-specification/tree/v1.2.1) (2019-08-14)