Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are tabular files in BIDS allowed to have any blank column names? #1105

Closed
VisLab opened this issue May 20, 2022 · 1 comment · Fixed by #1116
Closed

Are tabular files in BIDS allowed to have any blank column names? #1105

VisLab opened this issue May 20, 2022 · 1 comment · Fixed by #1116

Comments

@VisLab
Copy link
Member

VisLab commented May 20, 2022

I have read the spec several times and cannot determine whether this is allowed or not. (Tabular files are .tsv files with a column header as opposed to timeseries.tsv type files which do not have column headers.)

If blank column names are allowed, can there be an arbitrary number of them?

Corollary: If column names do not have to be unique, do the JSON sidecar keys apply to equally to all of the duplicates?

@sappelhoff
Copy link
Member

I just performed a short validator test and it does not warn or raise an error when column headers in TSV files are duplicated.

When column headers are blank, it raises a generic "empty cell" error, rather than a more appropriate "header missing" error:

[ERR] Empty cell in TSV file detected: The proper way of labeling missing values is "n/a". (code: 23 - TSV_EMPTY_CELL)

I also haven't found any rule in the spec whether duplicated headers and/or blank headers are allowed.

According to me, neither should be allowed, so I'd be up for adding a rule like:

Column headers in TSV files MUST be unique in the file and MUST NOT be empty (blank).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants