Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TSV validation: Error when column header is blank, duplicated, or "n/a" #1465

Closed
sappelhoff opened this issue Jun 7, 2022 · 2 comments · Fixed by #1488
Closed

TSV validation: Error when column header is blank, duplicated, or "n/a" #1465

sappelhoff opened this issue Jun 7, 2022 · 2 comments · Fixed by #1488
Labels
effort: medium Estimated medium effort task impact: low Estimated low impact task tsv files

Comments

@sappelhoff
Copy link
Member

sappelhoff commented Jun 7, 2022 •
edited
Loading

related to bids-standard/bids-specification#1105

We still need to add a note to the spec about this as well. done in bids-standard/bids-specification#1116
@sappelhoff sappelhoff added tsv files effort: medium Estimated medium effort task impact: low Estimated low impact task labels Jun 7, 2022
@sappelhoff sappelhoff mentioned this issue Jun 7, 2022
Merged
1 task
@sappelhoff sappelhoff changed the title TSV validation: Error when column header is blank or duplicated TSV validation: Error when column header is blank, duplicated, or n/a Jul 12, 2022
@sappelhoff sappelhoff changed the title TSV validation: Error when column header is blank, duplicated, or n/a TSV validation: Error when column header is blank, duplicated, or "n/a" Jul 12, 2022
@sappelhoff
Copy link
Member Author

@rwblair would you have some time in the next weeks to take this one on?

@rwblair
Copy link
Member

rwblair commented Jul 12, 2022

For sure. Looks like we have code to look for blank values, so I'll include the headers in that check. For duplicates I'll add new issue and check close to where we check for blank values.

@rwblair rwblair mentioned this issue Jul 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort: medium Estimated medium effort task impact: low Estimated low impact task tsv files
Projects
None yet
Milestone
No milestone
2 participants
@sappelhoff @rwblair