-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename modalities.yaml in schema #593
Comments
I'm leaning toward "instruments.yaml" after reading something @robertoostenveld wrote. Additionally, I like the idea of combining the EEG and iEEG data types (i.e., folders) under a shared instrument like "biopotential amplifiers" (again, per @robertoostenveld). What do folks think of this structure? ---
mri:
name: Magnetic Resonance Imaging
datatypes:
- anat
- dwi
- fmap
- func
bioamp:
name: Biopotential Amplification
datatypes:
- eeg
- ieeg
meg:
name: Magnetoencephalography
datatypes:
- meg
beh:
name: Behavioral experiments
datatypes:
- beh While this doesn't affect the specification at all at the moment, I think it would eventually impact the organization of the text. Currently, we have an MRI page with subsections for the different data types derived from the same instrument, while EEG and iEEG have separate pages. Ultimately, iEEG and EEG would also fall under one page (or major section) named "Biopotential Amplification". |
Although I like |
@yarikoptic the thing I wrote that @tsalo refers to is this https://docs.google.com/document/d/1cY-iZL8rtgDJ1-YVs1f2h5ugOiuK144zu4ju9UXZEGY/edit#heading=h.r2qz45a4irn1. It is not yet ready for wide dissemination, as I would like to get some more feedback from specific people before opening it up for wider discussion. But then... it clarifies the organization and naming proposed here. |
@robertoostenveld sorry, I knew it wasn't ready for dissemination, so I tried to hint around it, but the proposals there seemed to be directly relevant to this issue. |
Reegarding |
@robertoostenveld If I'm understanding correctly, you're saying that I should say that this can probably be changed later. Currently, @yarikoptic @robertoostenveld What do you both think of the organization I proposed? Basically demoting EEG and iEEG from "instruments" or "measurement techniques" down to just "datatypes" (and of course suffixes) and nesting both under "Biopotential Amplification"? I would end up splitting up the entity tables to match the new convention. |
Related to bids-standard#593.
The file modalities.yaml describes the technologies supported in the specification (e.g., MRI, EEG). Given that "modality" has its own meaning, and will soon have a distinct definition in Common principles (see #592), the naming of the file in the schema is misleading. Some viable alternatives might be "technologies.yaml" or "instruments.yaml".
The text was updated successfully, but these errors were encountered: