-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BEP-001 clarification thread #721
Comments
Hey @effigies Great to hear that you are working on this! The central idea of MP2RAGE is that you acquire largely the same image for two different inversion times that are hence T1 and PD-weighted. For effiency reasons, these two images usually have different flip angles, but they absolutely don't have to (whereas by definition they have to have different inversion times). I would, thus, like in my example datasets on osf, only use the -Gilles |
Okay, it looks like we need to remove |
That's a great catch, thanks @effigies. The |
You can do that or comment here. If this looks good enough to move to a |
For |
@effigies in absence of Is it feasible to accept both |
Moving discussion to bids-standard/bids-examples#245. I think we can push off expanding RTE/RTP to non-anatomical data in a backwards-compatible way to the next release. Nothing stops people from putting the metadata in unofficially for the moment. |
I'm working on getting some BEP-001 example datasets in shape prior to the spec release. As I have questions I'll post them here. Some of them may require spec clarification, so I'm opening the issue here rather than in the examples repo.
Working on ds-mp2rage, the current MP2RAGE files have the
inv
entity, but notflip
. This makes sense to me in that they co-vary, so either could have equally validly been chosen. That said, the template here declaresinv
andflip
are both required for MP2RAGE. That does not seem to match anything else in the spec, though. Is this a problem with the template?ds-mtsat initially had
acq-T1w
,acq-MTon
andacq-MToff
. I changed these toflip-2
,flip-1_mt-on
andflip-1_mt-off
. Was that correct? We'll need to add metadata, but that can go in examples, as long as we get the baseline issues done here.More questions to come as I come up with them.
cc @agahkarakuzu @Gilles86 @ChristophePhillips (please add other BEP-001/qMRI people I've missed) @bids-standard/maintainers
Converted datasets for your approval:
The text was updated successfully, but these errors were encountered: