Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Make flip optional for MP2RAGE #722

Merged
merged 1 commit into from
Feb 9, 2021
Merged

[FIX] Make flip optional for MP2RAGE #722

merged 1 commit into from
Feb 9, 2021

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Feb 4, 2021

References #721.

Changes proposed:

  • Make the flip entity optional for the MP2RAGE suffix.

@tsalo
Copy link
Member Author

tsalo commented Feb 4, 2021

I'm not 100% sure if flip should be optional or prohibited.

@effigies
Copy link
Collaborator

effigies commented Feb 4, 2021

Makes sense to me. Will defer to Agah and Gilles about whether there's any reason it should be disallowed.

@tsalo tsalo added the schema Issues related to the YAML schema representation of the specification. Patch version release. label Feb 6, 2021
effigies
effigies approved these changes Feb 9, 2021
View reviewed changes
Copy link
Collaborator

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go with this.

@effigies effigies added this to the 1.5.0 milestone Feb 9, 2021
@Gilles86
Copy link
Contributor

Gilles86 commented Feb 9, 2021

Sorry for my late reply. LGTM.

@effigies effigies merged commit 7cdeadf into bids-standard:master Feb 9, 2021
@sappelhoff sappelhoff changed the title FIX: Make flip optional for MP2RAGE [FIX] Make flip optional for MP2RAGE Feb 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@effigies effigies effigies approved these changes

@agahkarakuzu agahkarakuzu Awaiting requested review from agahkarakuzu

@Gilles86 Gilles86 Awaiting requested review from Gilles86

Assignees
No one assigned
Labels
schema Issues related to the YAML schema representation of the specification. Patch version release.
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@tsalo @effigies @Gilles86