[SCHEMA] Start drafting validation rules for ASL data #1060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## schema-sprint #1060 +/- ##
================================================
Coverage ? 71.50%
================================================
Files ? 9
Lines ? 930
Branches ? 0
================================================
Hits ? 665
Misses ? 265
Partials ? 0 ☔ View full report in Codecov by Sentry. |
effigies
reviewed
Apr 12, 2022
effigies
reviewed
Apr 12, 2022
effigies
reviewed
Apr 12, 2022
yarikoptic
reviewed
Apr 12, 2022
| selectors: | ||
| - suffix == "asl" | ||
| - sidecar contains "LabelingDuration" | ||
| - type(sidecar.LabelingDuration) == "array" |
There was a problem hiding this comment.
Sorry for my sparse appearance at the meetings. So do we have a grammar and interpreter already? (Since in general looks like python but this absent contains operand throws me off, not sure why not to use available in with swap of the arguments)
There was a problem hiding this comment.
In YAML:
- "LabelingDuration" in sidecarraises an error because of YAML parsing rules. But we also don't insist that people always use < instead of > so it seemed reasonable to have both directions.
tsalo
added
the
schema
Co-authored-by: Chris Markiewicz <[email protected]>
effigies
reviewed
Apr 15, 2022
effigies
reviewed
Apr 15, 2022
Co-authored-by: Chris Markiewicz <[email protected]>
…specification into schema-sprint-taylor
sappelhoff
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tackles validation rules for the following error codes: