-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SCHEMA] Specify column requirement levels for several tabular files #1061
Merged
effigies
merged 9 commits into
bids-standard:schema-sprint
from
effigies:schema/tsv-task
Apr 13, 2022
Merged
[SCHEMA] Specify column requirement levels for several tabular files #1061
effigies
merged 9 commits into
bids-standard:schema-sprint
from
effigies:schema/tsv-task
Apr 13, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## schema-sprint #1061 +/- ##
==============================================
Coverage 71.50% 71.50%
==============================================
Files 9 9
Lines 930 930
==============================================
Hits 665 665
Misses 265 265 ☔ View full report in Codecov by Sentry. |
tsalo
reviewed
Apr 12, 2022
tsalo
reviewed
Apr 12, 2022
tsalo
added
the
schema
Issues related to the YAML schema representation of the specification. Patch version release.
label
Apr 13, 2022
effigies
commented
Apr 13, 2022
Co-authored-by: Taylor Salo <[email protected]>
effigies
force-pushed
the
schema/tsv-task
branch
from
April 13, 2022 18:19
016eb45
to
d31c99d
Compare
tsalo
reviewed
Apr 13, 2022
effigies
force-pushed
the
schema/tsv-task
branch
from
April 13, 2022 18:35
d31c99d
to
069abd6
Compare
effigies
changed the title
SCHEMA: Initial shot at EEG channels and electrodes
SCHEMA: Specify column requirement levels for several tabular files
Apr 13, 2022
tsalo
approved these changes
Apr 13, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me.
sappelhoff
changed the title
SCHEMA: Specify column requirement levels for several tabular files
[SCHEMA] Specify column requirement levels for several tabular files
Jul 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
schema
Issues related to the YAML schema representation of the specification. Patch version release.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New ideas:
initial_columns
- a subset of columns defining an order; this assumes that you never have, e.g., the second column fixed while the first is variableunknown_column_metadata
- indicates whether additional columns MUST have definitions in a sidecar JSON