Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SCHEMA] Specify column requirement levels for several tabular files #1061

Merged
merged 9 commits into from
Apr 13, 2022

Conversation

effigies
Copy link
Collaborator

New ideas:

  • initial_columns - a subset of columns defining an order; this assumes that you never have, e.g., the second column fixed while the first is variable
  • Overriding term enums to restrict options
  • unknown_column_metadata - indicates whether additional columns MUST have definitions in a sidecar JSON

@effigies effigies requested a review from tsalo as a code owner April 12, 2022 19:48
@codecov
Copy link

codecov bot commented Apr 12, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.50%. Comparing base (269dc00) to head (069abd6).

Additional details and impacted files
@@              Coverage Diff               @@
##           schema-sprint    #1061   +/-   ##
==============================================
  Coverage          71.50%   71.50%           
==============================================
  Files                  9        9           
  Lines                930      930           
==============================================
  Hits                 665      665           
  Misses               265      265           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tsalo tsalo added the schema Issues related to the YAML schema representation of the specification. Patch version release. label Apr 13, 2022
@effigies effigies changed the title SCHEMA: Initial shot at EEG channels and electrodes SCHEMA: Specify column requirement levels for several tabular files Apr 13, 2022
Copy link
Member

@tsalo tsalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

@effigies effigies merged commit c2bbd19 into bids-standard:schema-sprint Apr 13, 2022
@effigies effigies deleted the schema/tsv-task branch April 13, 2022 18:53
@sappelhoff sappelhoff changed the title SCHEMA: Specify column requirement levels for several tabular files [SCHEMA] Specify column requirement levels for several tabular files Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
schema Issues related to the YAML schema representation of the specification. Patch version release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants