Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SCHEMA] Correlating existing validator issues to schema entries #1063

Merged
merged 11 commits into from
Apr 14, 2022

Conversation

bendhouseart
Copy link
Collaborator

@bendhouseart bendhouseart commented Apr 13, 2022

Adding existing code's from Validator Issues to entities in schema where REQUIRED if is defined.

e.g.

# where entity once looked like the following
MRIASLCommonMetadataFieldsM0Type:
    selectors:
    - modality == "MRI"
    - datatype == "perf"
    - suffix == "asl"
    - sidecar.M0Type == "Estimate"
    fields:
        M0Estimate: REQUIRED

It now contains a reference to the existing code in the validator:

MRIASLCommonMetadataFieldsM0Type:
    selectors:
    - modality == "MRI"
    - datatype == "perf"
    - suffix == "asl"
    - sidecar.M0Type == "Estimate"
    fields:
        M0Estimate:
            level: REQUIRED
            code:
                M0ESTIMATE_NOT_DEFINED: |
                You must define 'M0Estimate' for this file, in case 'M0Type' is defined as 'Estimate'. 
                'M0Estimate' is a single numerical whole-brain M0 value (referring to the M0 of blood), 
                only if obtained externally (for example retrieved from CSF in a separate measurement).

@tsalo tsalo added the schema Issues related to the YAML schema representation of the specification. Patch version release. label Apr 13, 2022
@codecov
Copy link

codecov bot commented Apr 13, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.50%. Comparing base (acb2d92) to head (c054ae5).

Additional details and impacted files
@@              Coverage Diff               @@
##           schema-sprint    #1063   +/-   ##
==============================================
  Coverage          71.50%   71.50%           
==============================================
  Files                  9        9           
  Lines                930      930           
==============================================
  Hits                 665      665           
  Misses               265      265           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bendhouseart bendhouseart marked this pull request as ready for review April 13, 2022 17:52
@effigies effigies merged commit a022462 into bids-standard:schema-sprint Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
schema Issues related to the YAML schema representation of the specification. Patch version release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants