-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SCHEMA] Correlating existing validator issues to schema entries #1063
Merged
effigies
merged 11 commits into
bids-standard:schema-sprint
from
bendhouseart:schema-sprint
Apr 14, 2022
Merged
[SCHEMA] Correlating existing validator issues to schema entries #1063
effigies
merged 11 commits into
bids-standard:schema-sprint
from
bendhouseart:schema-sprint
Apr 14, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsalo
added
the
schema
Issues related to the YAML schema representation of the specification. Patch version release.
label
Apr 13, 2022
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## schema-sprint #1063 +/- ##
==============================================
Coverage 71.50% 71.50%
==============================================
Files 9 9
Lines 930 930
==============================================
Hits 665 665
Misses 265 265 ☔ View full report in Codecov by Sentry. |
tsalo
reviewed
Apr 13, 2022
effigies
reviewed
Apr 13, 2022
effigies
reviewed
Apr 13, 2022
effigies
approved these changes
Apr 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
schema
Issues related to the YAML schema representation of the specification. Patch version release.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding existing code's from Validator Issues to entities in schema where
REQUIRED if
is defined.e.g.
It now contains a reference to the existing code in the validator: