-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SCHEMA] Encode requirement levels for dataset_description and genetic_info #1064
[SCHEMA] Encode requirement levels for dataset_description and genetic_info #1064
Conversation
7de3863
to
b6eb2f8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## schema-sprint #1064 +/- ##
==============================================
Coverage 71.50% 71.50%
==============================================
Files 9 9
Lines 930 930
==============================================
Hits 665 665
Misses 265 265 ☔ View full report in Codecov by Sentry. |
I think since NO_AUTHORS is a warning, it would be upgrading from OPTIONAL to RECOMMENDED, right? In any case, what if we had a "publication" level for the validator? The checks in this level wouldn't have to be derived from the specification, but would be necessary for data sharing. |
e2f23c3
to
48b100b
Compare
addd6d6
to
0b4158a
Compare
Two open questions I see:
Genetics.Database
directly? Or have some way of specifying a nested structure as its own object?